Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IrreducibleInt #213

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Remove IrreducibleInt #213

merged 3 commits into from
Sep 21, 2023

Conversation

mscroggs
Copy link
Member

@mscroggs mscroggs commented Sep 20, 2023

Remove the IrreducibleInt hack.

It seems locally that all the tests pass without it...

This is coupled with FEniCS/basix#702

@mscroggs mscroggs marked this pull request as draft September 20, 2023 20:27
@wence-
Copy link
Collaborator

wence- commented Sep 20, 2023

It's a long time, but I think this hack was put in because the simplex-based degree estimation code under-estimates the degrees of integrals on hypercubes (for reasons that I do not recall 😞 )

@mscroggs mscroggs marked this pull request as ready for review September 20, 2023 20:38
@mscroggs
Copy link
Member Author

It's a long time, but I think this hack was put in because the simplex-based degree estimation code under-estimates the degrees of integrals on hypercubes (for reasons that I do not recall 😞 )

Yes, the docstring of _reduce_degree says that's done but also not why. I think I've achieved the same result by checking the cell type inside _reduce_degree:

if isinstance(f, int) and v.ufl_domain().ufl_cell().cellname() not in ["quadrilateral", "hexahedron"]:

@mscroggs mscroggs merged commit e3c5fce into main Sep 21, 2023
19 checks passed
@mscroggs mscroggs deleted the mscroggs/irreducible-int branch September 21, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants