Remove unnecessary pip pinning #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we want to let users use old versions of pip? Is there some specific systems that haven’t updated their pip version for 2 years? |
Why should we care? We should not pin versions unnecessarily because it complicates packaging. |
|
I don't even think pip is necessary here - it should be possible to install all of our packages using any PEP-compliant tool, e.g. |
jhale
pushed a commit
that referenced
this pull request
Apr 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
* Update version number. * Fix * Correct tag ref * Use BaseArgument.__eq__ in Argument (#147) (cherry picked from commit e683148) * Oops! Bump version number. * Fix. * Bump version. * Updated to .md README (#275) * Kebab case in build-wheels.yml (#276) * Fixes for pypa packaging. * Correct documentation links (#277) * Remove unecessary pip pinning (#278) * Bump version. * Update version to 2024.2.0 * Try trusted publishing on pypi. * Remove version change. * Fix. * Tidy. * Simplify. --------- Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> Co-authored-by: Michal Habera <michal.habera@gmail.com> Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #227 (comment).