Transform global derivatives of Jacobian to reference derivatives in preprocessed_form
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
reviewed
Jul 7, 2021
ufl/algorithms/apply_derivatives.py
Outdated
| @@ -593,6 +591,25 @@ def _grad(self, o): | |||
| # 1) n = count number of Grads, get f | |||
| # 2) if not f.has_derivatives(n): return zero(...) | |||
|
|
|||
| def _grad_to_reference_grad(self, o, K): | |||
There was a problem hiding this comment.
Nitpick, this function doesn't need self I think, so could it just be a free function?
There was a problem hiding this comment.
Sure! I put it there because it is only used by the GradRuleset class, but I'm happy to move it
wence-
reviewed
Jul 7, 2021
| Override for specific types if other behaviour is needed.""" | ||
| if is_cellwise_constant(o): | ||
| return self.independent_terminal(o) | ||
| else: | ||
| # TODO: Which types does this involve? I don't think the | ||
| # form compilers will handle this. | ||
| return Grad(o) |
There was a problem hiding this comment.
I think you can also remove the TODO comment?
wence-
reviewed
Jul 7, 2021
garth-wells
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #62 and FEniCS/ffcx#373.