Signature computation speedup #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
reviewed
Mar 23, 2022
wence-
reviewed
Apr 22, 2022
wence-
reviewed
Apr 22, 2022
wence-
reviewed
Apr 22, 2022
pbrubeck
pushed a commit
to firedrakeproject/ufl
that referenced
this pull request
Nov 1, 2022
* Run unique traversal * Remove commented old code * Unique traversal with appended operands * Unique post traversal with cached ops * Apply hashing during post traversal * Convert bytes to hex directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: See comments for updates. Current solution is based on unique post traversal and computing hash at each node during the traversal.
For complicated UFL forms signature computation easily dominates JIT compilation, often even assembly times. Expression signatures are fetched e.g. in FFCx for disk caching - which contributes a unique hash into binary file name.
This PR changespre_traversaltounique_pre_traversalfor expression hashdata, which has significant 700x speedup in some cases (see cProfiler images below). Additionally, operands (their ufl typecode) are added to the generated hashdata to make it unique.