Fix interactive story counter #15
Closed
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rafael Teodosio <rafzteodosio@gmail.com>
Co-authored-by: joao vitor silva <joaovitordmrosa@hotmail.com>
Co-authored-by: Rafael Teodosio <rafzteodosio@gmail.com>
…ES/rasa into interactive-story-counter
Co-authored-by: Rafael Teodosio <rafzteodosio@gmail.com>
arthurTemporim
requested changes
Feb 24, 2021
rasa/core/training/interactive.py
Outdated
| @@ -75,6 +75,8 @@ | |||
|
|
|||
| MAX_VISUAL_HISTORY = 3 | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This is made according to style sheet?
There was a problem hiding this comment.
I don't remember doing that. I"ll change it.
rasa/core/training/interactive.py
Outdated
| @@ -816,10 +818,15 @@ def _write_stories_to_file( | |||
| else: | |||
| append_write = "w" # make a new file if not | |||
|
|
|||
| with open( | |||
| export_story_path, "r", encoding=rasa.shared.utils.io.DEFAULT_ENCODING | |||
There was a problem hiding this comment.
Why you are using "r"? Maybe do something like append_write variable in line 819 is better.
There was a problem hiding this comment.
In this code we are only reading the file to find the "interactive_story" string. There's no need to use append_write.
Co-authored-by: Rafael Teodosio <rafzteodosio@gmail.com>
…able Co-authored-by: Rafael Teodosio <rafzteodosio@gmail.com>
Co-authored-by: joao vitor silva <joaovitordmrosa@hotmail.com>
Co-authored-by: Rafael Teodosio <rafzteodosio@gmail.com>
Pull Request Test Coverage Report for Build 639324339
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status:
black(please check Readme for instructions)