Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model relative path to CLI commands logs #3

Merged
merged 43 commits into from
Oct 14, 2020
Merged

Conversation

lucasdutraf
Copy link
Collaborator

@lucasdutraf lucasdutraf commented Sep 29, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Henrike100
Copy link
Collaborator

I think it would be good to write the changelog.

@Henrike100
Copy link
Collaborator

Also, change this:

logger.info("Loading model {}...".format(model_relative_path))

to this:

logger.info(f"Loading model {model_relative_path}...")

@lucasdutraf
Copy link
Collaborator Author

Also, change this:

logger.info("Loading model {}...".format(model_relative_path))

to this:

logger.info(f"Loading model {model_relative_path}...")

Done @Henrike100 ! Thanks for your help! 😄

Copy link
Collaborator

@arthurTemporim arthurTemporim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears good to me :D

@lucasdutraf lucasdutraf force-pushed the model_name_logs branch 2 times, most recently from 58291cc to 3bc33af Compare October 6, 2020 15:40
@lucasdutraf lucasdutraf merged commit 419663c into master Oct 14, 2020
@iurisevero iurisevero deleted the model_name_logs branch February 21, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants