[ISSUE-38] Change size computation in getPackageInfoLocal #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thank you for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
Changes the way package size is computed in getPackageInfoLocal to avoid throwing a ModuleNotFound error (and thus returning an UNKNWON license) when the locally installed package is a namespace package (that cannot be loaded easily with
importlib.import_module)Which issue (if any) does this pull request address?
Fixes #38
Is there anything you'd like reviewers to focus on?
The size computed by metadata.Distribution is not the same as the on retrieved by PyPI (for published packages, ofc). These measurements can differ significantly but, since this information is actually of no use for license comparison, I wouldn't care very much about understanding the motivations of this difference and try to solve it.