fix: fixed docker workflow #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioRodriguezRuiz
requested review from
adrrf and
alvarobernal2412
as code owners
AntonioRodriguezRuiz
added
the
🐳 Dockerize
github-actions
bot
added
🚀 CI/CD
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- Dockerfile: Language not supported
AntonioRodriguezRuiz
added
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
469b200 to
376b157
Compare
AntonioRodriguezRuiz
added
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
376b157 to
a5a6217
Compare
AntonioRodriguezRuiz
added
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
a5a6217 to
6aa85c3
Compare
AntonioRodriguezRuiz
added
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
6aa85c3 to
f0b17c9
Compare
AntonioRodriguezRuiz
added
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
f0b17c9 to
f71238f
Compare
AntonioRodriguezRuiz
added
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
f71238f to
a2eee8d
Compare
AntonioRodriguezRuiz
added
the
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
a2eee8d to
1d703e2
Compare
alvarobernal2412
added
🐳 Dockerize
alvarobernal2412
force-pushed
the
fix/docker_deploy_workflow
branch
from
160f6b2 to
50e254e
Compare
alvarobernal2412
added
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
50e254e to
ffb59a0
Compare
AntonioRodriguezRuiz
added
🐳 Build
and removed
🐳 Dockerize
AntonioRodriguezRuiz
added
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
ffb59a0 to
ba71d3c
Compare
AntonioRodriguezRuiz
added
size/s
🐳 Dockerize
AntonioRodriguezRuiz
force-pushed
the
fix/docker_deploy_workflow
branch
from
ba71d3c to
db4cce9
Compare
alvarobernal2412
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the Docker deployment workflow to streamline the image building and pushing process. The most important changes involve modifying environment variables, updating job steps, and switching to a new action for multi-stage Docker builds.
Improvements to environment variables:
.github/workflows/docker-deploy.yml: UpdatedGHCR_IMAGEto dynamically format the image name based on the GitHub event type and branch reference. IntroducedIMAGE_NAMEfor better readability and maintainability.Changes to job steps:
.github/workflows/docker-deploy.yml: Removed steps for configuring QEMU, Docker Buildx, and logging into DockerHub, as they are no longer necessary..github/workflows/docker-deploy.yml: Updated theBuild and Push Ghcr Imagestep to use thefirehed/multistage-docker-build-actionfor a more efficient multi-stage Docker build process.For now only working on ghcr