Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: apiclient dispatch #44

Merged
merged 2 commits into from
Dec 30, 2024
Merged

ci: apiclient dispatch #44

merged 2 commits into from
Dec 30, 2024

Conversation

adrrf
Copy link
Contributor

@adrrf adrrf commented Dec 26, 2024

This pull request introduces a new GitHub Actions workflow to automate the generation and update of OpenAPI specifications for the Axios client. The workflow is designed to run on pushes and pull requests to the develop branch.

Key changes include:

  • Creation of a new workflow named 🔀OpenAPI - Axios Client in .github/workflows/openapi.yml.
  • The workflow is set to trigger on push and pull request events targeting the main branch.
  • Steps in the workflow include checking out the repository, caching dependencies, copying a configuration file, building the project, generating the OpenAPI specification, checking for schema modifications, committing changes if the schema is modified, and dispatching an event to the Axios client repository.

@github-actions github-actions bot added 🚀 CI/CD Indicates the change is related to CI/CD workflows size/s labels Dec 26, 2024
@adrrf adrrf force-pushed the feature/axiosclient branch from eb0eb1d to d9a0b9f Compare December 26, 2024 16:25
@adrrf adrrf force-pushed the feature/axiosclient branch from d9a0b9f to 8c6dcc0 Compare December 26, 2024 16:26
@adrrf adrrf self-assigned this Dec 26, 2024
@AntonioRodriguezRuiz
Copy link
Contributor

Please change deprecated if its gonna be deprecated before March
image

How does it differ if we use the example or prod variant? Which should be best?
image

The commit changes step does not execute

Have you tested the resulting axios client is usable?

@adrrf
Copy link
Contributor Author

adrrf commented Dec 28, 2024

Please change deprecated if its gonna be deprecated before March image

How does it differ if we use the example or prod variant? Which should be best? image

The commit changes step does not execute

Have you tested the resulting axios client is usable?

i have not tested the axios client, im currently fighting with the api gateway and kubernetes interconecting services, i will change the deprecated

Copy link
Contributor

@AntonioRodriguezRuiz AntonioRodriguezRuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarobernal2412 alvarobernal2412 merged commit 6ad0316 into main Dec 30, 2024
4 checks passed
@alvarobernal2412 alvarobernal2412 deleted the feature/axiosclient branch December 30, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 CI/CD Indicates the change is related to CI/CD workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants