Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bcos3client.py #201

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

RuslandGadget
Copy link
Contributor

The variable "bcos3sdk" in the class "Bcos3Client" should be renamed as "bcossdk". Otherwise, there will be the error: "AttributeError: 'Bcos3Client' object has no attribute 'bcossdk'".

The variable "bcos3sdk" in the class "Bcos3Client" should be renamed as "bcossdk". Otherwise, there will be the error:  "AttributeError: 'Bcos3Client' object has no attribute 'bcossdk'".
Copy link
Contributor

@coderkentzhang coderkentzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动可以减少代码的二义性。在该对象初始化的时候会给self.bcossdk赋值,所以正常使用流程应该不会报错,但在未初始化的场景分支会出错。

@coderkentzhang coderkentzhang merged commit 97986fa into FISCO-BCOS:master Nov 20, 2023
2 of 4 checks passed
@RuslandGadget RuslandGadget deleted the patch-1 branch November 20, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants