Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create more informative logs #1312

Closed
FR-ADDIX opened this issue Jan 25, 2023 · 5 comments
Closed

Create more informative logs #1312

FR-ADDIX opened this issue Jan 25, 2023 · 5 comments

Comments

@FR-ADDIX
Copy link

Is it possible to see in the log level "Error" also the triggering entity?

time=Wednesday 25 Jan 10:13:59 2023.173Z | lvl=ERROR | corr=N/A | trans=N/A | from=N/A | srv=N/A | subsrv=N/A | comp=Orion | op=orionldError.cpp[65]:orionldError | msg=***** ERROR null is not allowed as RHS in a JSON-LD document: value (status code: 400)

Or do I have to set another log level for it?

@kzangeli
Copy link
Collaborator

Sorry, that's not part of the implementation right now.
I admit the error handling and logging could be greatly improved.
However, for this particular error, it seems like you have a null as right-hand-side somewhere.
Should be quite easy to find (assuming you have the payload body)

@FR-ADDIX
Copy link
Author

Well, what here for an error occurs is already clear to recognize, but if this would be only an import and if the data would come then also still beautifully slowly one after the other.

At the moment there are about 7-9 processes importing data.
There are 200 - 300 imports per second.
4 or 5 of the imports are done by myself, the others are delivered externally.
If one could at least recognize the triggering entity, that would already point the way.

@kzangeli
Copy link
Collaborator

Yeah, I agree.
I could easily (I think! :)) add more info (entity id, attr name, sub attr name, etc) in the log. For this specific error!

@kzangeli
Copy link
Collaborator

kzangeli commented Jan 28, 2023

So, finally got some time to look into this issue.
Weekends are blessed! :)
Just me and my PC, no interruptions (well, my boss sometimes ... :))

Hope I fixed it, in PR #1314.
Test your stuff again, with the newest tag from dockerhub (if all goes well, it should be pushed in about 30 min) and if you're satisfied, please close this issue.

[ Due to the changes in error handling, I got a few errors in functests. Will take a bit longer than 30 min ]

kzangeli added a commit that referenced this issue Jan 28, 2023
More logging for attribute value == null in pCheckAttribute (user request, issue #1312)
@kzangeli kzangeli self-assigned this Jan 28, 2023
@FR-ADDIX
Copy link
Author

works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants