Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid tenant bad character in tenant name - #1344

Closed
thinkingmik opened this issue Mar 23, 2023 · 8 comments
Closed

Invalid tenant bad character in tenant name - #1344

thinkingmik opened this issue Mar 23, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@thinkingmik
Copy link

Hi,

I have an architectural question: is there a valid reason why the NGSILD-Tenant not allows -?

Could it be add this char in the tenant name in the future?

Thanks

@kzangeli
Copy link
Collaborator

It might be like that for no reason at all.
It might also be a mondodb related restriction
I'll look into it and let you know, right here in this issue.

@hendelali
Copy link

Is this somehow related to "Unable to extract tenants from the database - fatal error" when trying to install a fresh install in Docker? I have this issue and I'm just running either docker run fiware/orion-ld:1.1.1 or docker run fiware/orion-ld:latest in Mac environments. Same issue happens in Macs with Intel or Silicon procesors.

@kzangeli
Copy link
Collaborator

I don't think there's any connection with your problem.
We'll fix yours as well, don't worry ;-)

@kzangeli
Copy link
Collaborator

There's no mongo-related restrictions for the hyphen.
Now I need to make sure there's no NGSI-LD restriction and if not, I'll just go ahead and implement the change to accept hyphen as part of a tenant name

@kzangeli
Copy link
Collaborator

Also nothing in the NGSI-LD spec. No restrictions at all, in fact.
We need to work on that, but I will make sure the hyphen is an allowed character once we get there in ETSI ISG CIM (I sit in the "committee" that defines the NGSI-.LD API).

I added the hyphen as an allowed char, recompiled, modified a functerst to use a tenant with a hyphen and I tested it. All OK.
As this is next to nothing, I will include it in the PR I'm working on right now.

That PR should be merged into develop either late tonight or some time tomorrow.

@kzangeli kzangeli self-assigned this Mar 23, 2023
@kzangeli kzangeli added the enhancement New feature or request label Mar 23, 2023
@thinkingmik
Copy link
Author

Great!! Thank you very much!!!

kzangeli added a commit that referenced this issue Mar 23, 2023
kzangeli added a commit that referenced this issue Mar 23, 2023
@kzangeli
Copy link
Collaborator

So, it's done.
Test it and go ahead and close this issue if you're satisfied.

@thinkingmik
Copy link
Author

It's ok! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants