Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository schema] latestEP attribute is redundant #122

Closed
donmendelson opened this issue Mar 22, 2021 · 3 comments
Closed

[repository schema] latestEP attribute is redundant #122

donmendelson opened this issue Mar 22, 2021 · 3 comments
Assignees

Comments

@donmendelson
Copy link
Member

This attribute of <fields> is redundant to metadata for the repository

@kleihan
Copy link
Member

kleihan commented Mar 23, 2021

I believe this is a legacy feature from the Basic repository that had separate files for abbreviations, datatypes, enums, fields, components, messages, message contents, categories, sections. All of these files hat latestEP as an attribute of their root element. It indicates the last time an element within this group was added or updated. It is redundant as the highest EP number can easily be determined by a script checking the pedigree attributes (e.g. addedEP, updatedEP) of its sub-elements.

If we remove it for fields then it should also be removed for all other elements in the list above. The root element of the files in the Basic repository also had an attribute "version" that was redundant and only exists once in the Unified repository.

@donmendelson donmendelson changed the title [repository schema] latestEP attribute is reduandant [repository schema] latestEP attribute is redundant Jul 28, 2021
@donmendelson donmendelson added this to the Orchestra v1.1 milestone Aug 13, 2021
donmendelson added a commit to donmendelson/fix-orchestra that referenced this issue Nov 19, 2021
…ty#122

This is a small breaking change but reduces unnecessary maintenance.
@kleihan
Copy link
Member

kleihan commented Mar 4, 2023

The attribute still needs to be removed from the fields element, correct?

	<xs:element name="fields">
		<xs:complexType>
			<xs:sequence>
				<xs:element name="field" type="fixr:fieldType" minOccurs="0" maxOccurs="unbounded">
					<xs:key name="typeKey">
						<xs:selector xpath="."/>
						<xs:field xpath="@type|@codeSet"/>
					</xs:key>
				</xs:element>
				<xs:element name="annotation" type="fixr:annotation" minOccurs="0"/>
			</xs:sequence>
			<xs:attribute name="latestEP" type="fixr:EP_t"/>
			<xs:attribute ref="xml:base"/>
		</xs:complexType>
                ...

kleihan added a commit that referenced this issue Aug 29, 2023
Had been forgotten when removing it for the other top level elements.
@kleihan
Copy link
Member

kleihan commented Jun 3, 2024

Implemented in RC1

@kleihan kleihan closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants