Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository schema] Consider moving "Datatype" from repository.xsd's root level to repositoryType.xsd #190

Open
francescoloconte opened this issue Oct 20, 2023 · 2 comments · Fixed by #233
Assignees
Labels
ERRATA Errors and omissions, inconsistencies

Comments

@francescoloconte
Copy link

The repository.xsd file, allows containers for various elements at the root level, like Messages, Elements, Datatypes, etc. However, it also allows the Datatype element at the root level. Does this have a use case? Or should the Datatype be moved to the repositoryTypes.xsd file instead, where all other types reside?

image

@francescoloconte
Copy link
Author

Hello everyone. It would be useful if anyone could identify a use case for keeping datatype in repository.xsd. I could not find one and I am suggesting that we move it to repositoryType.xsd, where all other types are described.

@kleihan kleihan added the ERRATA Errors and omissions, inconsistencies label Aug 21, 2024
@patricklucas
Copy link
Contributor

I don't think datatype being defined in repository.xsd allows a <fixr:datatype /> element at the root of a repository, as the definition for repository still only includes datatypes, not datatype.

But I do agree that, for consistency with all the other second-level repository elements, we should move datatype into repositorytypes.xsd. As far as I understand, this should have no effect on users of these XSDs, as they are both defined in the same namespace, so even generated code would be in the same Java package, for instance—I believe the separation of the two XSD files is purely organizational.

patricklucas added a commit to patricklucas/fix-orchestra that referenced this issue Sep 10, 2024
@kleihan kleihan linked a pull request Sep 11, 2024 that will close this issue
@kleihan kleihan moved this to In progress in Orchestra v1.1 RC2 Sep 12, 2024
kleihan added a commit that referenced this issue Nov 4, 2024
[#190] Move `datatype` to repositorytypes.xsd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERRATA Errors and omissions, inconsistencies
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants