Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu CI Failing #426

Closed
Robadob opened this issue Dec 4, 2020 · 2 comments · Fixed by #429
Closed

Ubuntu CI Failing #426

Robadob opened this issue Dec 4, 2020 · 2 comments · Fixed by #429
Labels

Comments

@Robadob
Copy link
Member

Robadob commented Dec 4, 2020

The Ubuntu Github action image has updated, bringing with it CMake verison 3.19.

Googletest doesn't support this yet (), which is calling all ubuntu CI runs to fail.

Won't fix it ourselves just yet, hopefully Googletest will be updated in the very near future.

GTest issue: google/googletest#3040
GTest candidate PR: google/googletest#3094 (month old without being merged at time of writing).

@Robadob Robadob added the wontfix label Dec 4, 2020
@ptheywood
Copy link
Member

ptheywood commented Dec 4, 2020

Installing a pinned version (3.18.4) is a possible (temporary) fix:

The following action step appears to work. Windows is a bit less clear how to learn where --user goes intelligently...

- name: Install Specific Cmake version via Pip.
      run: |
        python3 -m pip install --user cmake==3.18.4
        echo "$(python3 -m site --user-base)/bin" >> $GITHUB_PATH

@ptheywood
Copy link
Member

#427 will be a short term fix for this, until a gtest update is available, and cmake > 3.18 can be used.

ptheywood added a commit that referenced this issue Jan 5, 2021
This appears to work locally with 3.19.2, but does output a warning re: CMAKE_MINIMUM_VERSION in rapidjson being deprecated
Closes #426
Robadob pushed a commit that referenced this issue Jan 13, 2021
This appears to work locally with 3.19.2, but does output a warning re: CMAKE_MINIMUM_VERSION in rapidjson being deprecated
Closes #426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants