-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Manylinux2014 -> Manylinux_2_28 and update deprecated actions #1228
base: master
Are you sure you want to change the base?
Conversation
ca0c56f
to
943e244
Compare
Wheels generated by the Manylinux_2_28 wheel seem to be missing some wrapped methods. Will need to investiagate when a bit more when on a machine with a GPU.
|
This will be due to swig 4.2.1 being included in the manylinux_2_28 containers. Could downgrade (and block swig 4.2?), but it would be better to fix the root cause (i.e. make pyflamegpu swig 4.2 compatible). See #956 |
…ithub actions Node 16 Github actions are deprecated, but node 20 actions are incompatible with Manylinux_2014/CentOS7. - Replaces manylinux wheel building to use 2_28 (based on Alma 8) - Updates depreacted actions in all workflows.
42f3959
to
9d234fd
Compare
When installing the wheels produced by the ManyLinux_2_28 image, they are still installable with incompatible glibc, but error at runtime:
(I believe) this is due to the wheel name being Our wheels are not strictly manylinux compliant (see #647), so I didn't enable the use of After manually running a repair on an individual wheel (which ran with no error code): $ auditwheel repair /tmp/pyflamegpu-2.0.0rc3+cuda120-cp310-cp310-linux_x86_64.whl --plat manylinux_2_28_x86_64
INFO:auditwheel.main_repair:Repairing pyflamegpu-2.0.0rc3+cuda120-cp310-cp310-linux_x86_64.whl
INFO:auditwheel.wheeltools:Previous filename tags: linux_x86_64
INFO:auditwheel.wheeltools:New filename tags: manylinux_2_28_x86_64
INFO:auditwheel.wheeltools:Previous WHEEL info tags: cp310-cp310-linux_x86_64
INFO:auditwheel.wheeltools:New WHEEL info tags: cp310-cp310-manylinux_2_28_x86_64
INFO:auditwheel.main_repair:
Fixed-up wheel written to /tmp/wheelhouse/pyflamegpu-2.0.0rc3+cuda120-cp310-cp310-manylinux_2_28_x86_64.whl attempting to install this wheel on CentOS7 errors:
However locally repairing the wheel with auditwheel repair packages Given this is an improvement (i.e. fixes CI) we should probably merge this as is, and just ensure that in our next / future release notes and probably in the wheelhouse state we require glibc >= 2_28 + raise #647 as a priority for a better pyflamegpu installation process (with nvidia providing cuda packages on pip now, we might be able to lean into that a little, though we might have to sitch to cuda 11.6+ iirc?) |
Node 16 Github actions are deprecated, but node 20 actions are incompatible with Manylinux_2014/CentOS7.
Produced wheels are still not technically Manylinux compliant due to linkage against non-packaged .so files (see #647)
This will reduce wheel compatibility, by increasing the required glibc to 2.28 or newer.
Closes #1190
Closes #1224
Replaces #1200 and #1194 as they must be coupled.
Todo
auditwheel repair
requires Add Manylinux_2_28 workflow #1194The use of download_artifact will not have been tested by CI, as it is only used if a version tag is created. We might want to do a dry run on a fork.