Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a better way to share data among clients per each class #87

Merged

Conversation

xehartnort
Copy link
Contributor

If tests are passing, everything should be ok

@xehartnort xehartnort requested a review from AlArgente June 22, 2023 11:42
@xehartnort xehartnort self-assigned this Jun 22, 2023
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
flex/data
   dataset.py122398%95, 213–214
   utils.py701579%107–123, 159
flex/datasets
   federated_datasets.py451371%19, 27–30, 40–55, 73, 86
   flexible_datasets.py11373%13, 30–31
flex/model
   model.py21481%30–33
flex/pool
   primitives.py501276%55–65, 194, 235–241
TOTAL9625095% 

Tests Skipped Failures Errors Time
115 0 💤 1 ❌ 0 🔥 14m 51s ⏱️

@xehartnort
Copy link
Contributor Author

Test are not passing completely, I need to imporve the bugfix

@AlArgente
Copy link
Contributor

An awesome solution to the bug. Nice work detecting the bug when splitting the classes among the clients :)

@AlArgente AlArgente merged commit 629c8d1 into main Jun 22, 2023
@xehartnort
Copy link
Contributor Author

<3

@xehartnort xehartnort deleted the FLEX-109-corregir-bug-reparticion-de-clases-por-cliente branch June 29, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants