Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding in fiter #93

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

xehartnort
Copy link
Contributor

Implement correct rounding in filter method. Also add a test to ensure perfect rounding. :)

@xehartnort xehartnort requested a review from AlArgente June 27, 2023 08:39
@xehartnort xehartnort self-assigned this Jun 27, 2023
@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
flex/data
   dataset.py122398%95, 213–214
   utils.py701579%107–123, 159
flex/datasets
   federated_datasets.py451371%19, 27–30, 40–55, 73, 86
   flexible_datasets.py11373%13, 30–31
flex/model
   model.py21481%30–33
flex/pool
   decorators.py53296%12–13
   primitives.py501276%55–65, 195, 236–242
TOTAL9775295% 

Tests Skipped Failures Errors Time
116 0 💤 1 ❌ 0 🔥 15m 5s ⏱️

@xehartnort
Copy link
Contributor Author

Ready to merge!

@AlArgente
Copy link
Contributor

Good name change. It's better to know the number of clients we use when applying the filter instead of working with the number of clients to dropout, can be confusing sometimes.

@AlArgente AlArgente merged commit f1946a2 into main Jun 27, 2023
@xehartnort xehartnort deleted the round-properly-number-of-nodes-in-filter branch June 29, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants