Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace filter with select new implementation, fix notebooks too #98

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

xehartnort
Copy link
Contributor

He aprovechado para también cambiar los .model por ["model"] en los notebooks, los he ejecutado todos para asegurarme de que no se han roto.

@xehartnort xehartnort requested a review from AlArgente June 28, 2023 11:57
@xehartnort xehartnort self-assigned this Jun 28, 2023
@xehartnort
Copy link
Contributor Author

xehartnort commented Jun 28, 2023

Para el futuro, deberíamos de encontrar alguna manera de meter un github action que ejecute los notebooks para asegurarnos siempre de que funcionan.

Seguramente podamos usar: https://testbook.readthedocs.io/en/latest/index.html para escribir tests propios de los notebooks

@xehartnort
Copy link
Contributor Author

Ready to merge as soon as tests finish :) 🔥

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
flex/common
   utils.py751580%119–135, 173
flex/data
   dataset.py122398%95, 213–214
flex/datasets
   federated_datasets.py451371%19, 27–30, 40–55, 73, 86
   flexible_datasets.py11373%13, 30–31
flex/pool
   primitives.py501276%55–65, 195, 236–242
TOTAL9764695% 

Tests Skipped Failures Errors Time
108 0 💤 1 ❌ 0 🔥 13m 29s ⏱️

@AlArgente AlArgente added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 28, 2023
@AlArgente
Copy link
Contributor

Great job, for changing the notebook and very good job with the notebooks!!

@AlArgente AlArgente merged commit fb026d1 into main Jun 28, 2023
@xehartnort xehartnort deleted the FLEX-114-cambiar-metodo-filter-a-metodo-select branch June 29, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants