fixed -- improved non x86_64 build times #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… were built from source
jennydaman
requested changes
May 2, 2022
Dockerfile
Outdated
| @@ -30,7 +30,7 @@ | |||
| # docker build --build-arg http_proxy=${PROXY} --build-arg ENVIRONMENT=local -t local/pfcon:dev . | |||
| # | |||
|
|
|||
| FROM docker.io/library/python:3.8.12-bullseye | |||
| FROM fnndsc/conda:latest | |||
There was a problem hiding this comment.
Never use the :latest tag, please pin a version.
Dockerfile
Outdated
| @@ -39,11 +39,12 @@ LABEL org.opencontainers.image.authors="FNNDSC <dev@babyMRI.org>" \ | |||
| org.opencontainers.image.source="https://github.com/FNNDSC/pfcon" \ | |||
| org.opencontainers.image.licenses="MIT" | |||
|
|
|||
| RUN conda install -y -c conda-forge msgpack-python==1.0.3 MarkupSafe==2.1.1 netifaces==0.10.9 PyYAML==6.0 wrapt==1.14.0 | |||
There was a problem hiding this comment.
conda prefers the name=version syntax instead of name==version (which is pip-specific).
Dockerfile
Outdated
| @@ -39,11 +39,12 @@ LABEL org.opencontainers.image.authors="FNNDSC <dev@babyMRI.org>" \ | |||
| org.opencontainers.image.source="https://github.com/FNNDSC/pfcon" \ | |||
| org.opencontainers.image.licenses="MIT" | |||
|
|
|||
| RUN conda install -y -c conda-forge msgpack-python==1.0.3 MarkupSafe==2.1.1 netifaces==0.10.9 PyYAML==6.0 wrapt==1.14.0 | |||
There was a problem hiding this comment.
Please specify these dependencies in an external file, such as one created by conda env export, see the documentation I sent to you in chat.
|
I am closing this generated a new pr #125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the base image and used conda to install those dependencies which required building from source.
in total there were 5 packages
msgpack-python==1.0.3
MarkupSafe==2.1.1
netifaces==0.10.9
PyYAML==6.0
wrapt==1.14.0
among them I downgraded netifaces from 0.11.0 to 0.10.9 since it was not available in the conda-forge channel