-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed -- improved non x86_64 build times #124
Conversation
… were built from source
Dockerfile
Outdated
@@ -30,7 +30,7 @@ | |||
# docker build --build-arg http_proxy=${PROXY} --build-arg ENVIRONMENT=local -t local/pfcon:dev . | |||
# | |||
|
|||
FROM docker.io/library/python:3.8.12-bullseye | |||
FROM fnndsc/conda:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never use the :latest
tag, please pin a version.
Dockerfile
Outdated
@@ -39,11 +39,12 @@ LABEL org.opencontainers.image.authors="FNNDSC <dev@babyMRI.org>" \ | |||
org.opencontainers.image.source="https://github.com/FNNDSC/pfcon" \ | |||
org.opencontainers.image.licenses="MIT" | |||
|
|||
RUN conda install -y -c conda-forge msgpack-python==1.0.3 MarkupSafe==2.1.1 netifaces==0.10.9 PyYAML==6.0 wrapt==1.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda prefers the name=version
syntax instead of name==version
(which is pip-specific).
Dockerfile
Outdated
@@ -39,11 +39,12 @@ LABEL org.opencontainers.image.authors="FNNDSC <dev@babyMRI.org>" \ | |||
org.opencontainers.image.source="https://github.com/FNNDSC/pfcon" \ | |||
org.opencontainers.image.licenses="MIT" | |||
|
|||
RUN conda install -y -c conda-forge msgpack-python==1.0.3 MarkupSafe==2.1.1 netifaces==0.10.9 PyYAML==6.0 wrapt==1.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify these dependencies in an external file, such as one created by conda env export
, see the documentation I sent to you in chat.
I am closing this generated a new pr #125 |
changed the base image and used conda to install those dependencies which required building from source.
in total there were 5 packages
msgpack-python==1.0.3
MarkupSafe==2.1.1
netifaces==0.10.9
PyYAML==6.0
wrapt==1.14.0
among them I downgraded netifaces from 0.11.0 to 0.10.9 since it was not available in the conda-forge channel