drupal in a day workshop certificated generated #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathamesh920
requested changes
May 7, 2018
certificate/views.py
Outdated
| @@ -2714,14 +2724,15 @@ def create_python_workshop_certificate(certificate_path, name, qrcode, type, pap | |||
| else: | |||
| template = '3day_template_PWS2017Pcertificate' | |||
|
|
|||
| # ws_date = '10 March 2018' or 'March 2018' | |||
There was a problem hiding this comment.
Please remove commented code.
certificate/models.py
Outdated
| @@ -172,6 +172,8 @@ class Drupal_WS(models.Model): | |||
| name = models.CharField(max_length=200) | |||
| email = models.EmailField() | |||
| purpose = models.CharField(max_length=10, default='DRP') | |||
| status = models.CharField(max_length=10, default='Participated') | |||
There was a problem hiding this comment.
status can be a Boolean instead of char.
certificate/models.py
Outdated
| @@ -172,6 +172,8 @@ class Drupal_WS(models.Model): | |||
| name = models.CharField(max_length=200) | |||
| email = models.EmailField() | |||
| purpose = models.CharField(max_length=10, default='DRP') | |||
| status = models.CharField(max_length=10, default='Participated') | |||
| ws_date = models.CharField(max_length=200, default='01 January 2016') | |||
There was a problem hiding this comment.
Instead of ws_date can we have simply date
Also, it can be date field instead of char
|
Looks good |
|
Merging for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.