Turret centers while intaking #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #115 |
|
I think we can have the intake command just adjust turret using set points then when finished collecting it goes back to locking as that's the default command. Should be faster and more intuitive that way. So I would not adjust locking in intake command |
|
Pitch should not need to change when locking onto speaker as the range works. Trap or Amp will need pitch adjusted |
ACat701
added
Tested
TaylerUva
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to rethink how I did the LockedPosition logic here, as the current implementation will also cause the pivot/hood to stop locking
Do we want to add any logic that waits for the turret to be centered before intaking?