Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto Placement LEDs #149

Merged
merged 11 commits into from
Feb 25, 2024
Merged

Auto Placement LEDs #149

merged 11 commits into from
Feb 25, 2024

Conversation

Alenguye582
Copy link
Contributor

No description provided.

@Alenguye582
made a constant for blank leds
c4b54c3 
need to push this to switch branches ahh
@Alenguye582
added logic to set leds when at the correct position
ce76dad 
this is more complicated than i thought it would be O.o
@Alenguye582 Alenguye582 added the Untested This pull request has not been tested at all label Feb 19, 2024
@Alenguye582
moved logic into RobotContainer
8254605 
it work :D
@Alenguye582
cleaned up and set the LEDs at the end
59b4546 
i have no idea how to get rid of the flickering :(
@Alenguye582
ahhh the rotation is working!!!!!
26596cc
@Alenguye582
created variables to store desired rotation and translation colors
89e06b6 
- also added feedback for translation
ahhh it actually works and the code is shorter too :D
@Alenguye582 Alenguye582 added Tested This pull request has been fully tested (on the real robot) and removed Untested This pull request has not been tested at all labels Feb 24, 2024
@Alenguye582 Alenguye582 linked an issue Feb 24, 2024 that may be closed by this pull request
LEDs when disabled to communicate placement for auto prior to a match (Alice's idea, https://youtu.be/aRY7PFJ0PF0?si=lLZTNuQqeonhHped) #141
Closed
@Alenguye582 Alenguye582 marked this pull request as ready for review February 24, 2024 17:30
@Alenguye582 Alenguye582 requested a review from a team as a code owner February 24, 2024 17:30
@ACat701
Copy link
Contributor

ACat701 commented Feb 25, 2024

I think we're good to merge this in
Getting the pose from the auto will be done when autos are added - we want this in main
@TaylerUva thoughts?

@TaylerUva
Copy link
Member

TaylerUva commented Feb 25, 2024 •
edited
Loading

I think we're good to merge this in

Getting the pose from the auto will be done when autos are added - we want this in main

@TaylerUva thoughts?

Sounds good. However,
There are merge conflicts @ACat701

@ACat701
Copy link
Contributor

ACat701 commented Feb 25, 2024

I think we're good to merge this in
Getting the pose from the auto will be done when autos are added - we want this in main
@TaylerUva thoughts?

Sounds good. However, There are merge conflicts @ACat701

github when imports 😨

@ACat701 ACat701 enabled auto-merge (squash) February 25, 2024 08:50
@ACat701 ACat701 merged commit bd28938 into main Feb 25, 2024
1 check passed
@ACat701 ACat701 deleted the disabled-leds branch February 25, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ACat701 ACat701 ACat701 left review comments

@TaylerUva TaylerUva TaylerUva approved these changes

Assignees
No one assigned
Labels
Tested This pull request has been fully tested (on the real robot)
Projects
None yet
Milestone
No milestone
3 participants
@Alenguye582 @ACat701 @TaylerUva