Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made Transfer check if ready to shoot🦟™️ #176

Merged
merged 14 commits into from
Feb 26, 2024
Merged

Conversation

BrodyKarr
Copy link
Contributor

No description provided.

@BrodyKarr BrodyKarr requested a review from a team as a code owner February 24, 2024 19:42
@TaylerUva TaylerUva added the Untested This pull request has not been tested at all label Feb 24, 2024
@BrodyKarr BrodyKarr enabled auto-merge (squash) February 24, 2024 21:05
@ACat701
Copy link
Contributor

ACat701 commented Feb 25, 2024

Closes #167
Closes #173

@ACat701
Copy link
Contributor

ACat701 commented Feb 25, 2024

@TaylerUva do we want this in main or do we want to wait until we fix the absolute encoders? Also, what's our plan from there? Vision? I just want to have a clear picture of how Tuesday should go. Unfortunately, I think we only have one meeting left for anything software-related so we really gotta make it count 🤞. I maybe could come in early on Tuesday (I have math 4 as my 5th period... i lowkey don't want to sit in there "learning" about e for 2.5 hours)

Stuff we need to do:

  • Abs Encoders
  • Vision testing
  • Auto (tuning, testing)
  • Amp preset a bit better
  • Trap attempted
  • Subwoofer preset a bit better
  • Further testing with auto-aim (once Vision is working)
  • Driver snapping to source and chain (once Vision is working, not as bad as it sounds)
  • Decide if we are keeping flywheels on all match or what

I'm thinking
Fix Abs Encoders -> Vision testing -> Subwoofer -> Amp -> Driver snapping -> Trap (very temporarily) -> flywheels??? -> Auto for the rest of our time

I really think i am forgetting something

@TaylerUva
Copy link
Member

Let's merge this in and fix in main.

My suggestion:

  1. Fix Abs Encoders (must do)
  2. Vision testing (must do)
  3. Trap functionality (1 hour)
  4. Auto functionality (let's get a least one working)
  5. Subwoofer (good enough already)
  6. Amp (good enough already)
  7. Driver snapping (🤷)

@TaylerUva
Copy link
Member

Good to merge @ACat701? I approve

@TaylerUva TaylerUva linked an issue Feb 25, 2024 that may be closed by this pull request
@BrodyKarr BrodyKarr merged commit db0c123 into main Feb 26, 2024
1 check passed
@BrodyKarr BrodyKarr deleted the only-shoot-when-ready branch February 26, 2024 00:05
@ACat701 ACat701 mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Untested This pull request has not been tested at all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock feeder to only feed at goal RPM and angles
3 participants