Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simulation visualization and Fix turret locking #230

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

ACat701
Copy link
Contributor

@ACat701 ACat701 commented Mar 12, 2024

AdvantageScope_(WPILib)_T4vyzHQluU

I exported the hood wrong so that's wrong in this clip... I need to fix that soon and then we'll talk about where to put the model asset. I'll probably just throw it in assets like last year. My drivebase is also missing colsons. I don't know whats up with that. AAND i need an icat. also don't know know whats up with that.

All of these todos aren't major, especially compared to the Turret Locking fix. If we want that in main, I'd be fine with merging this in and making these a separate issue

TODO:

  • Re-get hood model (the origin NEEDS to be in the center of the pivot point, and the planes need to be correct)
  • Test hood positioning in sim
  • Maybe fix the drivetrain model so i actually have wheels?
  • Add ICAT models
  • Upload robot model somewhere

@ACat701 ACat701 marked this pull request as ready for review March 12, 2024 07:07
@ACat701 ACat701 requested a review from a team as a code owner March 12, 2024 07:07
@ACat701 ACat701 enabled auto-merge (squash) March 12, 2024 07:07
@ACat701 ACat701 added the Tested in Sim This pull request has been tested, but not on the real robot label Mar 12, 2024
@TaylerUva
Copy link
Member

Where are the 3D models stored?

@ACat701
Copy link
Contributor Author

ACat701 commented Mar 12, 2024

Currently, just on my computer (but the hood is still wrong)

Do we want them in the assets folder or somewhere else?

@TaylerUva
Copy link
Member

TaylerUva commented Mar 12, 2024

Do we want them in the assets folder or somewhere else?

Depends on the size. Maybe as git lfs if they are large

@TaylerUva TaylerUva added Tested This pull request has been fully tested (on the real robot) and removed Tested in Sim This pull request has been tested, but not on the real robot labels Mar 13, 2024
@ACat701 ACat701 merged commit ab59324 into main Mar 13, 2024
1 check passed
@ACat701 ACat701 deleted the simulation-support branch March 13, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested This pull request has been fully tested (on the real robot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants