Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for Final Release #282

Merged
merged 30 commits into from
Apr 13, 2024
Merged

Cleanup for Final Release #282

merged 30 commits into from
Apr 13, 2024

Conversation

ACat701
Copy link
Contributor

@ACat701 ACat701 commented Apr 6, 2024 •
edited
Loading

TODOs

  • Don't call the preset "Leapfrog" anymore bc nobody called it that :(
  • Fix all of the climber units because they are WRONG!
  • Fix intake pivot visualization in sim (We flipped the direction it moved physically... i forgot about the sim part)
    - [ ] Update PDH Ports No longer using them since they weren't used anyway!
  • Go through all of the preferences
  • Add images of sim to the readme
  • Await upload of CAD and update the README to reference where to get the AdvantageScope Model

ACat701 and others added 20 commits March 30, 2024 20:23
@ACat701
Fix units for Drivetrain Pose Estimator
f558b14
@ACat701
Remove unused imports
da14a7d
@Alenguye582
remove MORE unused imports
93b3457 
woah all the files are white now :0
@ACat701
Add Back Vision (because it still works)
60fbb4d
@ACat701
Merge branch 'health-and-wellness' of https://github.com/FRCTeam3255/…
aba0b99 
…2024_Robot_Code into health-and-wellness
@ACat701
Clean up autos
c8d917b
@Alenguye582
reorganized and labeled robot preferences
dbf73da
@Alenguye582
Merge branch 'health-and-wellness' of https://github.com/FRCTeam3255/…
af1f0ce 
…2024_Robot_Code into health-and-wellness
@ACat701
Update Controller Maps
528d049
@ACat701
Merge branch 'health-and-wellness' of https://github.com/FRCTeam3255/…
9eac3b8 
…2024_Robot_Code into health-and-wellness
@Alenguye582
deleted unused preference....in constants o.O
3eac693
@Alenguye582
removed unused preference
614a25f 
also changed a transfer preference to correct preference (they're the same value anyway so i didn't explode anything)
@Alenguye582
update readme but i can't write :(
e2dea1c
@ACat701
Move all inversions to constants
850151a
@ACat701
Merge branch 'health-and-wellness' of https://github.com/FRCTeam3255/…
981ef56 
…2024_Robot_Code into health-and-wellness
@ACat701
Guess who re-implemented vision wrong and then saw this comment
4c88e16
@ACat701
Clean RobotContainer
ba70912
@ACat701
Remove the part of the Conventions that we didn't follow + PDH ports
cd87378
@ACat701
Went through all of the preferences (Aside from climber ones)
da9c099
@ACat701
Fix Climber Positioning (Might wanna test this one)
7075a28
@ACat701
Copy link
Contributor Author

ACat701 commented Apr 6, 2024 •
edited
Loading

Things to test on the bot:

  • Climber still works
  • Pivot still works and is accurate

@ACat701 ACat701 marked this pull request as ready for review April 12, 2024 23:15
@ACat701 ACat701 requested a review from a team as a code owner April 12, 2024 23:15
@ACat701 ACat701 enabled auto-merge (squash) April 12, 2024 23:15
@ACat701
Copy link
Contributor Author

ACat701 commented Apr 12, 2024

STILL NEED ELI'S CAD >:(

@ACat701 ACat701 merged commit f044d95 into main Apr 13, 2024
1 check passed
@ACat701 ACat701 deleted the health-and-wellness branch April 13, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaylerUva TaylerUva TaylerUva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ACat701 @TaylerUva @Alenguye582