Turret Testing #61
Merged
Turret Testing #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaylerUva
reviewed
Jan 31, 2024
|
We may want to have a Field class |
|
Looks really good so far! Excited to see this running |
…into turret-prints-and-commands
It needs to be referenced by multiple subsystems
|
|
|
This pr has gotten insanely huge and I'm not quite sure how to feel about it We could consider moving all of the locking logic into its own PR just to have some of these changes in main (I made a few housekeeping changes) |
We could merge this in as we've been testing with this branch and we could do a secondary clean up PR |
TaylerUva
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56