Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web fixes #46

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Web fixes #46

merged 9 commits into from
Mar 20, 2024

Conversation

Karinon
Copy link
Collaborator

@Karinon Karinon commented Mar 19, 2024

This is a collection of several smaller fixes:

  • fixed issue where the databrowser has shown an undefined-flavour when none was selected under certain circumstances
  • replaced plain HTTPResponses by JSONResponses when the passed data was indeed a JSON
  • added error message when react didn't load properly (prior to that: No info at all)
  • added error message when there are issues with the user information (LDAP unreachable, Redis down) in one of the react-views (prior to that: infinite load animation)
  • some smaller visual changes

@Karinon
Copy link
Collaborator Author

Karinon commented Mar 19, 2024

The failed CI-Checks are black-formatting issues and you have already fixed them in your own PR, therefore I will not touch it

@antarcticrainforest
Copy link
Member

I can't really say much, most of the changes are beyond my knowledge. The only comment I have is about the HTTPResponse -> JSONRespons. There's more of them :)

@Karinon Karinon merged commit 15acf9f into solr_api Mar 20, 2024
1 of 3 checks passed
@Karinon Karinon deleted the web_fixes branch March 20, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants