Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data treaming #68

Merged
merged 17 commits into from
Dec 12, 2024
Merged

Data treaming #68

merged 17 commits into from
Dec 12, 2024

Conversation

BiancaWentzel
Copy link

Data is now shown as streamed.
The styling would be the next part I am working on, for now the basic functionality should be merged.

Copy link
Collaborator

@Karinon Karinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the few Nitpicks.

I assume you are aware that the user sees the JSON-Sub-Documents during the streaming (I guess this is the "styling"-part).

Furthermore, at some point you have to move the API-Key and freva_config from the react-part to proxyviews.py, but this is already an issue in frevagpt and doesn't necessarily need to be addressed in this branch.

bot/proxyviews.py Show resolved Hide resolved
assets/js/Containers/FrevaGPT/index.js Outdated Show resolved Hide resolved
@BiancaWentzel
Copy link
Author

f463de6 Fixes the styling issue (at least for markdown rendering). For some weird reason the conditional rendering of the component prevented realtime rendering of markdown

Copy link
Collaborator

@Karinon Karinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has not particularly something to do with this PR, but I noticed some unexpected behaviour when cancelling the bot, either by clicking New Chat during some streaming or clicking the Stop-Button while Analyzing Code.

I haven't gone through the whole code to find the culprits but at least New chat has to make sure, that the streaming stops entirely for the last thread. Let me know if you need further assistance with this.

@BiancaWentzel BiancaWentzel merged commit c153a90 into frevagpt Dec 12, 2024
3 checks passed
@BiancaWentzel BiancaWentzel deleted the data-treaming branch December 12, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants