-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick Fix: Improve rich console logger. #203
Conversation
Lgtm |
The tests are failing, unfortunately I can't see why. |
@antarcticrainforest, I've noticed an issue with the latest version of the MariaDB image! It was working well on my machine but on github action NO! To resolve the current red pipeline and fix MariaDB lost connection in our CI jobs, I've rolled back to version 11.3 here, which was working fine and I got connected MariDB, and green pipeline in result ... @grooverdan FYI |
Thanks for the hint @MoSHad91 |
From this there is:
MariaDB 11.4 is a Ubuntu noble base and < 11.3 is jammy (or focal for 10.4). Ubuntu has added a user to the base container MariaDB uses:
I'm fairly sure I can remove this user without impact. If you do add a Alternate mariadb:11.4-ubi is a UBI based image. That doesn't have a id 1000. I couldn't obviously see anything in your Dockerfile that was ubuntu specific so that may work too. |
#204 - quick fix |
FYI I've taken the default ubuntu user out of the noble based images - MariaDB/mariadb-docker@fb46c56 - you could revert #204 optionally if you want only newer stable images. |
Thanks @grooverdan, I explained the current issue with more detail in #236 |
This improves the logger output that is displayed in jupyter notebooks.