Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix: Improve rich console logger. #203

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

antarcticrainforest
Copy link
Member

This improves the logger output that is displayed in jupyter notebooks.

@eelucio
Copy link
Contributor

eelucio commented Jun 10, 2024

Lgtm

@antarcticrainforest
Copy link
Member Author

The tests are failing, unfortunately I can't see why.

@mo-dkrz
Copy link
Contributor

mo-dkrz commented Jun 18, 2024

The tests are failing, unfortunately I can't see why.

@antarcticrainforest, I've noticed an issue with the latest version of the MariaDB image! It was working well on my machine but on github action NO! To resolve the current red pipeline and fix MariaDB lost connection in our CI jobs, I've rolled back to version 11.3 here, which was working fine and I got connected MariDB, and green pipeline in result ...

@grooverdan FYI

@antarcticrainforest
Copy link
Member Author

The tests are failing, unfortunately I can't see why.

@antarcticrainforest, I've noticed an issue with the latest version of the MariaDB image! It was working well on my machine but on github action NO! To resolve the current red pipeline and fix MariaDB lost connection in our CI jobs, I've rolled back to version 11.3 here, which was working fine and I got connected MariDB, and green pipeline in result ...

@grooverdan FYI

Thanks for the hint @MoSHad91

@grooverdan
Copy link
Contributor

From this there is:

0.097 + groupadd -r --gid 1000 freva
0.099 groupadd: GID '1000' already exists

MariaDB 11.4 is a Ubuntu noble base and < 11.3 is jammy (or focal for 10.4).

Ubuntu has added a user to the base container MariaDB uses:

$ podman run --rm  mariadb:11.4 bash -c 'getent group 1000 ; id 1000'
ubuntu:x:1000:
uid=1000(ubuntu) gid=1000(ubuntu) groups=1000(ubuntu),4(adm),20(dialout),24(cdrom),25(floppy),27(sudo),29(audio),30(dip),44(video),46(plugdev)

I'm fairly sure I can remove this user without impact. If you do add a userdel / groupdel can you make it non fatal for when I update the image.

Alternate mariadb:11.4-ubi is a UBI based image. That doesn't have a id 1000. I couldn't obviously see anything in your Dockerfile that was ubuntu specific so that may work too.

@grooverdan
Copy link
Contributor

#204 - quick fix

@antarcticrainforest antarcticrainforest merged commit e9367ce into main Jun 19, 2024
11 checks passed
@antarcticrainforest antarcticrainforest deleted the console-logger-fix branch June 19, 2024 06:50
@antarcticrainforest antarcticrainforest restored the console-logger-fix branch June 19, 2024 06:52
@grooverdan
Copy link
Contributor

FYI I've taken the default ubuntu user out of the noble based images - MariaDB/mariadb-docker@fb46c56 - you could revert #204 optionally if you want only newer stable images.

@mo-dkrz
Copy link
Contributor

mo-dkrz commented Oct 15, 2024

FYI I've taken the default ubuntu user out of the noble based images - MariaDB/mariadb-docker@fb46c56 - you could revert #204 optionally if you want only newer stable images.

Thanks @grooverdan, I explained the current issue with more detail in #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants