Skip to content

Commit

Permalink
zebra: Give a bit more data about zclient connection on errors
Browse files Browse the repository at this point in the history
When debugging a crash I noticed that sometimes we talked about
a zclient connection in relation to the fd associated with it
and sometimes we did not.  Let's just always give the data
associated with the fd.  It will make it a bit easier for me
to follow the transitions.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
  • Loading branch information
donaldsharp committed Dec 13, 2024
1 parent f7720ab commit 3a53b2d
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions zebra/zserv.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,9 @@ void zserv_log_message(const char *errmsg, struct stream *msg,
*/
static void zserv_client_fail(struct zserv *client)
{
flog_warn(
EC_ZEBRA_CLIENT_IO_ERROR,
"Client '%s' (session id %d) encountered an error and is shutting down.",
zebra_route_string(client->proto), client->session_id);
flog_warn(EC_ZEBRA_CLIENT_IO_ERROR,
"Client %d '%s' (session id %d) encountered an error and is shutting down.",
client->sock, zebra_route_string(client->proto), client->session_id);

atomic_store_explicit(&client->pthread->running, false,
memory_order_relaxed);
Expand Down Expand Up @@ -468,8 +467,8 @@ static void zserv_read(struct event *thread)
}

if (IS_ZEBRA_DEBUG_PACKET)
zlog_debug("Read %d packets from client: %s. Current ibuf fifo count: %zu. Conf P2p %d",
p2p_avail - p2p, zebra_route_string(client->proto),
zlog_debug("Read %d packets from client: %s(%d). Current ibuf fifo count: %zu. Conf P2p %d",
p2p_avail - p2p, zebra_route_string(client->proto), client->sock,
client_ibuf_fifo_cnt, p2p_orig);

/* Reschedule ourselves since we have space in ibuf_fifo */
Expand Down

0 comments on commit 3a53b2d

Please sign in to comment.