Skip to content

Commit

Permalink
watchfrr: increase restart timer 20s -> 90s
Browse files Browse the repository at this point in the history
This commit:
"tools: run `vtysh -b` once for all-startup"

changed things so that `vtysh -b` is run after all daemons have started
up instead of doing it for each daemon as they are started up. This
results in one long `vtysh -b`, which for large configs and many daemons
(in the case I saw, 4 daemons and 30,000 line config) can exceed the 20
second timer watchfrr uses to kill "hung" background tasks.

Shouldn't be any harm to increasing this to 90 seconds to give us some
leeway while still making sure we kill anything truly misbehaving.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
  • Loading branch information
qlyoung authored and donaldsharp committed Dec 7, 2024
1 parent 4c1d75c commit 9406c43
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion watchfrr/watchfrr.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

#define DEFAULT_PERIOD 5
#define DEFAULT_TIMEOUT 90
#define DEFAULT_RESTART_TIMEOUT 20
#define DEFAULT_RESTART_TIMEOUT 90
#define DEFAULT_LOGLEVEL LOG_INFO
#define DEFAULT_MIN_RESTART 60
#define DEFAULT_MAX_RESTART 600
Expand Down

0 comments on commit 9406c43

Please sign in to comment.