Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: update kernel routes with interface check #17668

Closed
wants to merge 1 commit into from

Conversation

ykholod
Copy link

@ykholod ykholod commented Dec 18, 2024

#13561

Kernel routes are not always properly updated in zebra. When an IP address is flushed from an interface route is still present in zebra.
Steps to reproduce:
ip link set dev eth0 up
ip -4 addr add 192.168.0.2/24 dev eth0
ip -4 route add default via 192.168.0.1
ip -4 addr flush dev eth0

Current fix adds extra validation before setting NH Active.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Zebra NH check is wrong -- it does not update missing interface routes

Steps to reproduce:
```
ip link set dev eth0 up
ip -4 addr add 192.168.0.2/24 dev eth0
ip -4 route add default via 192.168.0.1
ip -4 addr flush dev eth0
```

Before
```
K>* 0.0.0.0/0 [0/0] via 192.168.0.1, eth0, 00:00:07
```

After
Route is removed from zebra

Signed-off-by: Yaroslav Kholod <y.kholod@vyos.io>
@ykholod
Copy link
Author

ykholod commented Dec 19, 2024

These changes were done before me in here -- https://github.com/FRRouting/frr/pull/17544/files
Closing PR as non-valid.

@ykholod ykholod closed this Dec 19, 2024
@ykholod
Copy link
Author

ykholod commented Dec 19, 2024

These changes were done before me in here -- https://github.com/FRRouting/frr/pull/17544/files
Closing PR as non-valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant