zebra: update kernel routes with interface check #17668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ykholod
force-pushed
the
master-13561
branch
from
4f917c4 to
69bf312
Compare
Zebra NH check is wrong -- it does not update missing interface routes Steps to reproduce: ``` ip link set dev eth0 up ip -4 addr add 192.168.0.2/24 dev eth0 ip -4 route add default via 192.168.0.1 ip -4 addr flush dev eth0 ``` Before ``` K>* 0.0.0.0/0 [0/0] via 192.168.0.1, eth0, 00:00:07 ``` After Route is removed from zebra Signed-off-by: Yaroslav Kholod <y.kholod@vyos.io>
ykholod
force-pushed
the
master-13561
branch
from
69bf312 to
29ab572
Compare
|
These changes were done before me in here -- https://github.com/FRRouting/frr/pull/17544/files |
|
These changes were done before me in here -- https://github.com/FRRouting/frr/pull/17544/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13561
Kernel routes are not always properly updated in zebra. When an IP address is flushed from an interface route is still present in zebra.
Steps to reproduce:
ip link set dev eth0 upip -4 addr add 192.168.0.2/24 dev eth0ip -4 route add default via 192.168.0.1ip -4 addr flush dev eth0Current fix adds extra validation before setting NH Active.