atomic_add_fetch_explicit doesn't compile on all platforms

[louberger]

see https://ci1.netdef.org/browse/FRR-FRRPULLREQ-CI003BUILD-5076
function introduced in #2933
...
28-Aug-2018 13:58:15 | lib/lib_clippy-memory.o: In function mt_count_alloc': 28-Aug-2018 13:58:15 | /home/ci/cibuild.5076/frr-source/lib/memory.c:42: undefined reference to atomic_add_fetch_explicit'
28-Aug-2018 13:58:15 | /home/ci/c

[mjstapp]

Hmm, wow, sorry to have broken something. are you certain that that fork has picked up the commit that introduced the new atomics? I do see that new api with an old gcc, but I don't seem to be able to look at the fork repo myself.

[louberger]

what fork repo? you mean the PR?  Click changes on the pr or the link to the source repo&branch? Also yes, some platforms passed which means that the code is there on those platforms.

…

On 8/29/2018 9:42 AM, Mark Stapp wrote: Hmm, wow, sorry to have broken something. are you certain that that fork has picked up the commit that introduced the new atomics? I do see that new api with an old gcc, but I don't seem to be able to look at the fork repo myself. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2936 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGRWyCu5bV2m2Fo_0IWcRjBbhJdQ2ev2ks5uVpoogaJpZM4WQj5s>.

[mjstapp]

by "fork repo" I meant "the labnconsulting repo where your fork lives" - I thought I would try to build with your branch, but I don't have access to it. I was able to use that new atomic on openbsd6 with gcc 4.2 and on ubuntu 14 with some slightly less old gcc 4, but just using frrouting master. I guess I will try setting up a freebsd 10 vm and repeating that test.

[mjstapp]

got it - stdatomic.h does not include aliases for all of the available gcc atomic primitives, which we seemed to have been relying on. sorry about that - will fix...

[mjstapp]

Should be fixed by PR 2942.