-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: convert to SPDX License identifiers #12780
*: convert to SPDX License identifiers #12780
Conversation
New "introduction" note in `COPYING`, and all the licenses moved into `doc/licenses/`. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This comment was marked as outdated.
This comment was marked as outdated.
The files converted in this commit either had some random misspelling or formatting weirdness that made them escape automated replacement, or have a particularly "weird" licensing setup (e.g. dual-licensed.) This also marks a bunch of "public domain" files as SPDX License "NONE". Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Done with a combination of regex'ing and banging my head against a wall. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
The skiplist code has a very "colorful" history. Use the SPDX "LicenseRef" syntax/notation to track it. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
YANG files get to keep their license boilerplate in addition to the SPDX header, since they are likely to be copied around individually. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
The regex'ing left some paragraphs that didn't exactly match. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
e532814
to
0d60d63
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9602/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
|
Using // style comments for the SPDX license identifier was kind of an intentional choice to make it stand out as "directive-like" comment (and also to constrain it to the one line.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9618/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
|
Title says most of it already.
NB: I have, intentionally, converted only files that have a clear license. There are a few files around where the license can be cleared up with a little bit of detective work and/or confirming with people, but that is a separate work item and separate PR.
Public domain files are flagged as
SPDX-License-Identifier: NONE
since "public domain" isn't really a license.For review, the "manual" conversion commit probably needs the most attention. The auto-convert commit shouldn't really have much potential for errors sneaking in since it mechanically matched.