watchfrr: Extend ignore option to daemon being killed (backport #14618) #14624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
When testing GR features, it is desired to kill bgp (or really any daemon )and not immediately have bgp start up again. Modify the code to not attempt to restart the daemon by hand to let us developers work when the `watchfrr ignore XXX` command is issued. Testing: watchfrr ignore bgpd kill -9 bgpd start bgp by `/usr/lib/frr/watchfrr.sh start bgpd` at some point in time in the future leaf-1# show watchfrr watchfrr global phase: Idle Restart Command: "/usr/lib/frr/watchfrr.sh restart %s" Start Command: "/usr/lib/frr/watchfrr.sh start %s" Stop Command: "/usr/lib/frr/watchfrr.sh stop %s" Min Restart Interval: 60 Max Restart Interval: 600 Restart Timeout: 90 zebra Up bgpd Up/Ignoring Timeout staticd Up leaf-1# Signed-off-by: Donald Sharp <sharpd@nvidia.com> (cherry picked from commit c168244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #14618 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com