-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: "default-originate" shouldn't withdraw non-default routes #15032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent "default-originate" from withdrawing non-default routes like 0.0.0.0/1 by checking prefix length. Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
ton31337
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can we have a topotest and check if we don't touch 0.0.0.0/X?
Ensure that 0.0.0.0/1 route can be advertised along with default-originate. Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
@Mergifyio backport stable/9.1 stable/9.0 stable/8.5 |
✅ Backports have been created
|
This was referenced Dec 18, 2023
donaldsharp
added a commit
that referenced
this pull request
Dec 18, 2023
bgpd: "default-originate" shouldn't withdraw non-default routes (backport #15032)
donaldsharp
added a commit
that referenced
this pull request
Dec 18, 2023
bgpd: "default-originate" shouldn't withdraw non-default routes (backport #15032)
donaldsharp
added a commit
that referenced
this pull request
Dec 18, 2023
bgpd: "default-originate" shouldn't withdraw non-default routes (backport #15032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent "default-originate" from withdrawing non-default routes like 0.0.0.0/1 by checking prefix length.