Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: "default-originate" shouldn't withdraw non-default routes #15032

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

leonshaw
Copy link
Contributor

Prevent "default-originate" from withdrawing non-default routes like 0.0.0.0/1 by checking prefix length.

Prevent "default-originate" from withdrawing non-default routes like
0.0.0.0/1 by checking prefix length.

Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we have a topotest and check if we don't touch 0.0.0.0/X?

Ensure that 0.0.0.0/1 route can be advertised along with
default-originate.

Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
@frrbot frrbot bot added the tests Topotests, make check, etc label Dec 18, 2023
@github-actions github-actions bot added size/S and removed size/XS labels Dec 18, 2023
@ton31337 ton31337 merged commit 24ecc73 into FRRouting:master Dec 18, 2023
9 checks passed
@ton31337
Copy link
Member

@Mergifyio backport stable/9.1 stable/9.0 stable/8.5

Copy link

mergify bot commented Dec 18, 2023

backport stable/9.1 stable/9.0 stable/8.5

✅ Backports have been created

donaldsharp added a commit that referenced this pull request Dec 18, 2023
bgpd: "default-originate" shouldn't withdraw non-default routes (backport #15032)
donaldsharp added a commit that referenced this pull request Dec 18, 2023
bgpd: "default-originate" shouldn't withdraw non-default routes (backport #15032)
donaldsharp added a commit that referenced this pull request Dec 18, 2023
bgpd: "default-originate" shouldn't withdraw non-default routes (backport #15032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants