Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: include route source set by route-map in show output #16008

Merged
merged 1 commit into from
May 15, 2024

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented May 14, 2024

Include the prefix source address when set by a route-map in show output for routes, in various formats.
Add some debugs when encoding netlink route messages with a source address.

Include the prefix source address when set by a route-map in
show output for routes, in various formats.
Add some debugs when encoding netlink route messages with
a source address.

Signed-off-by: Mark Stapp <mjs@cisco.com>
@frrbot frrbot bot added the zebra label May 14, 2024
@riw777 riw777 self-requested a review May 14, 2024 15:14
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented May 14, 2024

consistent ci failure here --

E AssertionError: 'r1' wrong number of route nexthops assert [1, 1, 1, 1, 2, 2, 3, 3, 3] == [1, 1, 1, 1, 2, 3, 3, 3, 3] At index 5 diff: 2 != 3 Full diff: - [1, 1, 1, 1, 2, 3, 3, 3, 3] ? --- + [1, 1, 1, 1, 2, 2, 3, 3, 3] ? +++

but only on debian (?) ... might need to be looked at?

@mjstapp
Copy link
Contributor Author

mjstapp commented May 14, 2024

thanks - I'll take a look...

consistent ci failure here --

E AssertionError: 'r1' wrong number of route nexthops assert [1, 1, 1, 1, 2, 2, 3, 3, 3] == [1, 1, 1, 1, 2, 3, 3, 3, 3] At index 5 diff: 2 != 3 Full diff: - [1, 1, 1, 1, 2, 3, 3, 3, 3] ? --- + [1, 1, 1, 1, 2, 2, 3, 3, 3] ? +++

but only on debian (?) ... might need to be looked at?

@riw777 riw777 merged commit db1e2a0 into FRRouting:master May 15, 2024
11 checks passed
@mjstapp mjstapp deleted the show_routemap_source branch May 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants