Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Fix remote-as with peer-group #17542

Merged
merged 2 commits into from
Dec 3, 2024
Merged

bgpd: Fix remote-as with peer-group #17542

merged 2 commits into from
Dec 3, 2024

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Dec 1, 2024

Closes #17541

@ton31337
bgpd: Initialize as_type for peer-group as AS_UNSPECIFIED
e57fb32 
Previously AS_UNSPECIFIED was treated as 0, but with now it's 1 after renumbering
peer_asn_type enum.

Fixes: 0dfe256 ("bgpd: Implement neighbor X remote-as auto")

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@ton31337
tests: Check if remote-as is not flushed once peer-group applied
6f1ad10 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@frrbot frrbot bot added bgp bugfix tests Topotests, make check, etc labels Dec 1, 2024
@ton31337 ton31337 mentioned this pull request Dec 1, 2024
Closed
2 tasks
@c-po
Copy link
Contributor

c-po commented Dec 1, 2024

I can confirm this fixes the issue in question. Please create a backport for stable/10.2

@ton31337
Copy link
Member Author

ton31337 commented Dec 1, 2024

@Mergifyio backport stable/10.2

@mergify Mergify
Copy link

mergify bot commented Dec 1, 2024 •
edited
Loading

backport stable/10.2

✅ Backports have been created

riw777
riw777 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit e9c9db0 into FRRouting:master Dec 3, 2024
18 checks passed
@mergify mergify bot mentioned this pull request Dec 3, 2024
Closed
@ton31337 ton31337 deleted the fix/peer-group_remote_as_regression branch December 3, 2024 15:09
@ton31337 ton31337 mentioned this pull request Dec 5, 2024
Closed
2 tasks
@ichdasich ichdasich mentioned this pull request Dec 5, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
backport bgp bugfix master size/M tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bgp: defining peer-group for neighbor will remove remote-as setting
3 participants
@ton31337 @c-po @riw777