-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: Fix evpn bestpath calculation when path is not established #17613
Merged
riw777
merged 1 commit into
FRRouting:master
from
donaldsharp:evpn_bgp_bestpath_failure
Dec 17, 2024
Merged
bgpd: Fix evpn bestpath calculation when path is not established #17613
riw777
merged 1 commit into
FRRouting:master
from
donaldsharp:evpn_bgp_bestpath_failure
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 |
✅ Backports have been created
|
Hm, seems valid failures, right regarding GR? |
doesn't fail at home unless I put the system under major stress. I'll figure it out |
donaldsharp
force-pushed
the
evpn_bgp_bestpath_failure
branch
from
December 11, 2024 15:35
26715a0
to
e911a1b
Compare
Loading status checks…
If you have a bestpath list that looks something like this: <local evpn mac route> <learned from peer out swp60> <learned from peer out swp57> And a network event happens that causes the peer out swp60 to not be in an established state, yet we still have the path_info for the destination for swp60, bestpath will currently end up with this order: <learned from peer out swp60> <local evpn mac route> <learned from peer out swp57> This causes the local evpn mac route to be deleted in zebra( Wrong! ). This is happening because swp60 is skipped in bestpath calculation and not considered to be a path yet it stays at the front of the list. Modify bestpath calculation such that when pulling the unsorted_list together to pull path info's into that list when they are also not in a established state. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
donaldsharp
force-pushed
the
evpn_bgp_bestpath_failure
branch
from
December 11, 2024 17:27
e911a1b
to
9f88cb5
Compare
riw777
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This was referenced Dec 17, 2024
ton31337
added a commit
that referenced
this pull request
Dec 17, 2024
Loading
Loading status checks…
bgpd: Fix evpn bestpath calculation when path is not established (backport #17613)
ton31337
added a commit
that referenced
this pull request
Dec 17, 2024
Loading
Loading status checks…
bgpd: Fix evpn bestpath calculation when path is not established (backport #17613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a bestpath list that looks something like this:
And a network event happens that causes the peer out swp60 to not be in an established state, yet we still have the path_info for the destination for swp60, bestpath
will currently end up with this order:
This causes the local evpn mac route to be deleted in zebra( Wrong! ).
This is happening because swp60 is skipped in bestpath calculation and not considered to be a path yet it stays at the front of the list.
Modify bestpath calculation such that when pulling the unsorted_list together to pull path info's into that list when they are also not in a established state.