Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Take ge/le into consideration when checking the prefix with the prefix-list #17615

Merged
merged 1 commit into from
Dec 17, 2024
Merged

lib: Take ge/le into consideration when checking the prefix with the prefix-list #17615

merged 1 commit into from
Dec 17, 2024

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Dec 10, 2024 •
edited
Loading

Closes #17612

@ton31337
lib: Take ge/le into consideration when checking the prefix with the …
dd4c2ac 
…prefix-list

Without the fix:

```
show ip prefix-list test_1 10.20.30.96/27 first-match
 <no result>

show ip prefix-list test_2 192.168.1.2/32 first-match
 <no result>
```

With the fix:

```
ip prefix-list test_1 seq 10 permit 10.20.30.64/26 le 27
!
end
donatas# show ip prefix-list test_1 10.20.30.96/27
   seq 10 permit 10.20.30.64/26 le 27 (hit count: 1, refcount: 0)
donatas# show ip prefix-list test_1 10.20.30.64/27
   seq 10 permit 10.20.30.64/26 le 27 (hit count: 2, refcount: 0)
donatas# show ip prefix-list test_1 10.20.30.64/28
donatas# show ip prefix-list test_1 10.20.30.126/26
   seq 10 permit 10.20.30.64/26 le 27 (hit count: 3, refcount: 0)
donatas# show ip prefix-list test_1 10.20.30.126/30
donatas#
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@frrbot frrbot bot added the libfrr label Dec 10, 2024
@ton31337 ton31337 mentioned this pull request Dec 10, 2024
Closed
2 tasks
@riw777 riw777 self-requested a review December 10, 2024 16:27
riw777
riw777 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ton31337
Copy link
Member Author

@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 stable/8.5

@mergify Mergify
Copy link

mergify bot commented Dec 10, 2024 •
edited
Loading

backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 stable/8.5

✅ Backports have been created

@riw777 riw777 merged commit acea7d5 into FRRouting:master Dec 17, 2024
14 checks passed
@ton31337 ton31337 deleted the fix/ip_prefix_list_show_prefix branch December 17, 2024 16:31
This was referenced Dec 17, 2024
Merged
Merged
Merged
Merged
Merged
Merged
ton31337 added a commit that referenced this pull request Dec 17, 2024
@ton31337
Merge pull request #17656 from FRRouting/mergify/bp/stable/10.2/pr-17615
7740d3d 
lib: Take ge/le into consideration when checking the prefix with the prefix-list (backport #17615)
ton31337 added a commit that referenced this pull request Dec 17, 2024
@ton31337
Merge pull request #17657 from FRRouting/mergify/bp/stable/10.1/pr-17615
d4db705 
lib: Take ge/le into consideration when checking the prefix with the prefix-list (backport #17615)
Jafaral added a commit that referenced this pull request Dec 18, 2024
@Jafaral
Merge pull request #17658 from FRRouting/mergify/bp/stable/10.0/pr-17615
cbe7fc3 
lib: Take ge/le into consideration when checking the prefix with the prefix-list (backport #17615)
Jafaral added a commit that referenced this pull request Dec 18, 2024
@Jafaral
Merge pull request #17659 from FRRouting/mergify/bp/stable/9.1/pr-17615
ad14f7a 
lib: Take ge/le into consideration when checking the prefix with the prefix-list (backport #17615)
Jafaral added a commit that referenced this pull request Dec 18, 2024
@Jafaral
Merge pull request #17660 from FRRouting/mergify/bp/stable/9.0/pr-17615
241073f 
lib: Take ge/le into consideration when checking the prefix with the prefix-list (backport #17615)
ton31337 added a commit that referenced this pull request Dec 18, 2024
@ton31337
Merge pull request #17661 from FRRouting/mergify/bp/stable/8.5/pr-17615
fb3b95b 
lib: Take ge/le into consideration when checking the prefix with the prefix-list (backport #17615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
backport libfrr master size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show ip-prefixlist first-match doesn't match le or ge entries
2 participants
@ton31337 @riw777