Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Validate only affected RPKI prefixes instead of a full RIB (backport #17586) #17698

Closed
wants to merge 1 commit into from
Closed

bgpd: Validate only affected RPKI prefixes instead of a full RIB (backport #17586) #17698

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 20, 2024

Closes #17533

This is an automatic backport of pull request #17586 done by Mergify.

@ton31337 @mergify
bgpd: Validate only affected RPKI prefixes instead of a full RIB
850d6ca 
Before this fix, if rpki_sync_socket_rtr socket returns EAGAIN, then ALL routes
in the RIB are revalidated which takes lots of CPU and some unnecessary traffic,
e.g. if using BMP servers. With a full feed it would waste 50-80Mbps.

Instead we should try to drain an existing pipe (another end), and revalidate
only affected prefixes.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit b0800bf)

# Conflicts:
#	bgpd/bgp_rpki.c
@mergify mergify bot added the conflicts label Dec 20, 2024
@mergify Mergify
Copy link
Author

mergify bot commented Dec 20, 2024

Cherry-pick of b0800bf has failed:

On branch mergify/bp/stable/10.0/pr-17586
Your branch is up to date with 'origin/stable/10.0'.

You are currently cherry-picking commit b0800bfdf.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   bgpd/bgpd.c
	modified:   bgpd/bgpd.h

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bgpd/bgp_rpki.c

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Dec 20, 2024
Merged
@frrbot frrbot bot added the bgp label Dec 20, 2024
@ton31337 ton31337 closed this Dec 20, 2024
@ton31337 ton31337 deleted the mergify/bp/stable/10.0/pr-17586 branch December 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bgp size/L stable/10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ton31337