Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ospf6d: ECMP for external routes #1797

Merged
merged 1 commit into from
Mar 2, 2018
Merged

ospf6d: ECMP for external routes #1797

merged 1 commit into from
Mar 2, 2018

Conversation

chiragshah6
Copy link
Member

The route being added check its origin matches, with any of the existing path (list of paths).
Remove the existing path, add if its cost is eqaual or less than any of the existing path.

For a given route and of existing path cost is lower (better) than one being added, discard new route update.

The existing path cost is higher (lower) than one being added, ospf6_route_add replaces existing with new route info.

Compare cost between delete request and with existing route.

Ticket:CM-16139

Signed-off-by: Chirag Shah chirag@cumulusnetworks.com

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2665/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Failed

Checkout code: Failed

CheckPatch failed for Checkout code:

Report for ospf6_asbr.c
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #229: FILE: /tmp/f1/ospf6_asbr.c:229:
< +			 * origin. */
< 
--
< WARNING: Block comments use a trailing */ on a separate line
< #288: FILE: /tmp/f1/ospf6_asbr.c:288:
< +					 * nh_list */
< 
--
< WARNING: Block comments use a trailing */ on a separate line
< #408: FILE: /tmp/f1/ospf6_asbr.c:408:
< +			 * route has better cost. */
< 
< WARNING: Block comments use a trailing */ on a separate line
< #414: FILE: /tmp/f1/ospf6_asbr.c:414:
< +		 * replaces current with new route info */
< 
--
< WARNING: Block comments use a trailing */ on a separate line
< #630: FILE: /tmp/f1/ospf6_asbr.c:630:
< +				 * route info.*/
< 
--
< WARNING: Block comments use a trailing */ on a separate line
< #728: FILE: /tmp/f1/ospf6_asbr.c:728:
< +			 * if any check fails skip del this route node. */
< 
Report for ospf6_asbr.h
===============================================
Report for ospf6_route.c
===============================================
Report for ospf6_top.c
===============================================

@FRRouting FRRouting deleted a comment from NetDEF-CI Feb 24, 2018
@FRRouting FRRouting deleted a comment from NetDEF-CI Feb 24, 2018
@FRRouting FRRouting deleted a comment from NetDEF-CI Feb 24, 2018
@FRRouting FRRouting deleted a comment from NetDEF-CI Feb 24, 2018
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

OmniOS amd64 build: Successful
Debian9 amd64 build: Successful
Ubuntu 16.04 i386: Successful
NetBSD7 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
CentOS6 amd64 build: Successful
FreeBSD9 amd64 build: Successful
CentOS7 amd64 build: Successful
Ubuntu1204 amd64 build: Successful
FreeBSD10 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
Debian8 amd64 build: Successful
OpenBSD60 amd64 build: Successful
Fedora24 amd64 build: Successful
NetBSD6 amd64 build: Successful

FreeBSD11 amd64 build: Failed

Configure failed for FreeBSD11 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/artifact/CI009BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... no
checking for PYTHON... yes
checking whether we found a working Python version... no
configure: error: in `/usr/home/ci/cibuild.2666/frr-source':
configure: error: could not find python-config or pkg-config python, please install Python development files from libpython-dev or similar
See `config.log' for more details

FreeBSD11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/artifact/CI009BUILD/config.log/config.log

@LabN-CI
Copy link
Collaborator

LabN-CI commented Feb 24, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1797 bf2873f
Date 02/23/2018
Start 19:20:13
Finish 19:42:55
Run-Time 22:42
Total 1805
Pass 1805
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-02-23-19:20:13.txt
Log autoscript-2018-02-23-19:20:49.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

OmniOS amd64 build: Successful
Debian9 amd64 build: Successful
Ubuntu 16.04 i386: Successful
NetBSD7 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
CentOS6 amd64 build: Successful
FreeBSD9 amd64 build: Successful
CentOS7 amd64 build: Successful
Ubuntu1204 amd64 build: Successful
FreeBSD10 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
Debian8 amd64 build: Successful
OpenBSD60 amd64 build: Successful
Fedora24 amd64 build: Successful
NetBSD6 amd64 build: Successful

FreeBSD11 amd64 build: Failed

Configure failed for FreeBSD11 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/artifact/CI009BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... no
checking for PYTHON... yes
checking whether we found a working Python version... no
configure: error: in `/usr/home/ci/cibuild.2666/frr-source':
configure: error: could not find python-config or pkg-config python, please install Python development files from libpython-dev or similar
See `config.log' for more details

FreeBSD11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/artifact/CI009BUILD/config.log/config.log

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
Fedora 24 rpm pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Debian 9 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
Static analyzer (clang): Successful
IPv6 protocols on Ubuntu 14.04: Successful
CentOS 6 rpm pkg check: Successful
Ubuntu 16.04 deb pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2666/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-02-23 17:45:45,166 ERROR: assert failed at "test_ospf_topo1/test_ospf6_convergence": OSPF6 did not converge on r1:
  --- Current output
  +++ Expected output
  @@ -8,5 +8,6 @@
    N E1 2001:db8:100::/64 fe80::xxxx:xxxx:xxxx:xxxx r1-eth1 
   *N IE 2001:db8:200::/64 fe80::xxxx:xxxx:xxxx:xxxx r1-eth1 
    N E1 2001:db8:200::/64 fe80::xxxx:xxxx:xxxx:xxxx r1-eth1 
  + N E1 2001:db8:200::/64 fe80::xxxx:xxxx:xxxx:xxxx r1-eth1 
   *N IE 2001:db8:300::/64 fe80::xxxx:xxxx:xxxx:xxxx r1-eth1 
    N E1 2001:db8:300::/64 fe80::xxxx:xxxx:xxxx:xxxx r1-eth1
assert False

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

  • Github Pull Request 1797, comparing to Git base SHA f12f08f

No Changes in Static Analysis warnings compared to base

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2666/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Mar 1, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1797 6aabf57
Date 03/01/2018
Start 01:55:16
Finish 02:18:13
Run-Time 22:57
Total 1808
Pass 1808
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-03-01-01:55:16.txt
Log autoscript-2018-03-01-01:55:55.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2702/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for ospf6_asbr.c
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #214: FILE: /tmp/f1/ospf6_asbr.c:214:
< +	 * delete old entry */
< 
--
< WARNING: Block comments use a trailing */ on a separate line
< #749: FILE: /tmp/f1/ospf6_asbr.c:749:
< +			 * if any check fails skip del this route node. */
<

CLANG Static Analyzer Summary

  • Github Pull Request 1797, comparing to Git base SHA c98f4d8

No Changes in Static Analysis warnings compared to base

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2702/artifact/shared/static_analysis/index.html

@chiragshah6
ospf6d: ECMP for external routes
07b37f9 
The route being added check its origin matches,
with any of the existing path (list of paths).
Remove the existing path, add if its cost is
eqaual or less than any of the existing path.

For a given route and of existing path cost is lower
(better) than one being added, discard new route update.

The existing path cost is higher (lower) than one being
added, ospf6_route_add replaces existing with new route
info.

Compare cost between delete request and with existing
route.

Ticket:CM-16139

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Mar 1, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1797 07b37f9
Date 03/01/2018
Start 10:50:17
Finish 11:13:07
Run-Time 22:50
Total 1805
Pass 1805
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-03-01-10:50:17.txt
Log autoscript-2018-03-01-10:50:52.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2705/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 1797, comparing to Git base SHA c98f4d8

No Changes in Static Analysis warnings compared to base

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2705/artifact/shared/static_analysis/index.html

@riw777 riw777 merged commit 6768912 into FRRouting:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chiragshah6 @NetDEF-CI @LabN-CI @riw777