lib, ripnd: Isolate aggreagate pointer to using protocol #2715

donaldsharp · 2018-07-25T01:40:41Z

The void *aggregate pointer in ROUTE_NODE_FIELDS is only used by ripngd.
As such every single route_node in the system is paying the cost
of keeping this pointer around and never using it. Follow the table.h
design pattern in bgp_table.h and create a struct ripng_node pointer
that actually has this aggregate pointer and then provide ripng
specific struct route_node <-> struct ripng_node translator functions.

On a 64 bit system this should account for 8 bytes of data per route_node
which is not insignificant considering a full bgp feed in both bgp and
zebra, or evpn routes which make signficant usage of tables.

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

donaldsharp · 2018-07-25T01:41:06Z

ripngd/ripng_interface.c

 #include "ripngd/ripng_debug.h"

 /* If RFC2133 definition is used. */
 #ifndef IPV6_JOIN_GROUP
-#define IPV6_JOIN_GROUP  IPV6_ADD_MEMBERSHIP 
+#define IPV6_JOIN_GROUP IPV6_ADD_MEMBERSHIP


Intentional whitespace removal it was annoying me.

LabN-CI · 2018-07-25T01:50:51Z

🛑 Basic BGPD CI results: FAILURE

Results table

_	_
Result	FAILURE git merge/2715 `cb1eaf3` frr.github Build
Date	07/24/2018
Start	21:50:17
Finish	21:50:48
Run-Time	00:31
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2018-07-24-21:50:17.txt
Log	make-2018-07-24-21:50:17.out.bz2

For details, please contact louberger

NetDEF-CI · 2018-07-25T01:52:19Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1204 amd64 build: Successful

FreeBSD9 amd64 build: Failed

Make failed for FreeBSD9 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI004BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244: error: 'struct route_node' has no member named 'aggregate'

FreeBSD9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI004BUILD/config.status/config.status

Ubuntu 16.04 i386: Failed

Ubuntu 16.04 i386: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/U1604I386/config.status/config.status
Make failed for Ubuntu 16.04 i386:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

CentOS7 amd64 build: Failed

Make failed for CentOS7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

CentOS7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/U1804AMD64/config.status/config.status
Make failed for Ubuntu 18.04 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

FreeBSD10 amd64 build: Failed

Make failed for FreeBSD10 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI003BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229:8: error: 'struct route_node' has no member named 'aggregate'
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: 'struct route_node' has no member named 'aggregate'
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

FreeBSD10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI003BUILD/config.status/config.status

Ubuntu1404 amd64 build: Failed

Make failed for Ubuntu1404 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

Ubuntu1404 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI001BUILD/config.status/config.status

Debian8 amd64 build: Failed

Make failed for Debian8 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

Debian8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI008BLD/config.status/config.status

OmniOS amd64 build: Failed

Make failed for OmniOS amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI010BUILD/ErrorLog/log_make.txt)

checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking whether gcc supports -diag-error 10006... no
checking whether gcc supports -std=gnu11... yes
checking whether gcc -std=gnu11 supports -g... yes
checking whether gcc -std=gnu11 supports -Os... yes
checking whether gcc -std=gnu11 supports -fno-omit-frame-pointer... yes
checking whether gcc -std=gnu11 supports -funwind-tables... yes
checking whether gcc -std=gnu11 supports -Wall... yes

OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI010BUILD/config.status/config.status

OpenBSD60 amd64 build: Failed

Make failed for OpenBSD60 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244: error: 'struct route_node' has no member named 'aggregate'

OpenBSD60 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI011BUILD/config.status/config.status

Debian9 amd64 build: Failed

Debian9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI021BUILD/config.status/config.status
Make failed for Debian9 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

NetBSD7 amd64 build: Failed

Make failed for NetBSD7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229:8: error: 'struct route_node' has no member named 'aggregate'
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: 'struct route_node' has no member named 'aggregate'
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

NetBSD7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI012BUILD/config.status/config.status

Ubuntu1604 amd64 build: Failed

Make failed for Ubuntu1604 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

Ubuntu1604 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI014BUILD/config.status/config.status

FreeBSD11 amd64 build: Failed

Make failed for FreeBSD11 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229:8: error: 'struct route_node' has no member named 'aggregate'
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: 'struct route_node' has no member named 'aggregate'
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

FreeBSD11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI009BUILD/config.status/config.status

CentOS6 amd64 build: Failed

Make failed for CentOS6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI006BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:237: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:237: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:237: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:237: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:244: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:244: error: struct route_node has no member named aggregate

CentOS6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI006BUILD/config.status/config.status

NetBSD6 amd64 build: Failed

Make failed for NetBSD6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229:8: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244:15: error: 'struct route_node' has no member named 'aggregate'

NetBSD6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI007BUILD/config.status/config.status

Fedora24 amd64 build: Failed

Make failed for Fedora24 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI015BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

Fedora24 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI015BUILD/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings:

FreeBSD9 amd64 build: Failed

Make failed for FreeBSD9 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI004BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244: error: 'struct route_node' has no member named 'aggregate'

FreeBSD9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI004BUILD/config.status/config.status

Ubuntu 16.04 i386: Failed

Ubuntu 16.04 i386: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/U1604I386/config.status/config.status
Make failed for Ubuntu 16.04 i386:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

CentOS7 amd64 build: Failed

Make failed for CentOS7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

CentOS7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/U1804AMD64/config.status/config.status
Make failed for Ubuntu 18.04 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

FreeBSD10 amd64 build: Failed

Make failed for FreeBSD10 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI003BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229:8: error: 'struct route_node' has no member named 'aggregate'
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: 'struct route_node' has no member named 'aggregate'
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

FreeBSD10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI003BUILD/config.status/config.status

Ubuntu1404 amd64 build: Failed

Make failed for Ubuntu1404 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

Ubuntu1404 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI001BUILD/config.status/config.status

Debian8 amd64 build: Failed

Make failed for Debian8 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

Debian8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI008BLD/config.status/config.status

OmniOS amd64 build: Failed

Make failed for OmniOS amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI010BUILD/ErrorLog/log_make.txt)

checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking whether gcc supports -diag-error 10006... no
checking whether gcc supports -std=gnu11... yes
checking whether gcc -std=gnu11 supports -g... yes
checking whether gcc -std=gnu11 supports -Os... yes
checking whether gcc -std=gnu11 supports -fno-omit-frame-pointer... yes
checking whether gcc -std=gnu11 supports -funwind-tables... yes
checking whether gcc -std=gnu11 supports -Wall... yes

OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI010BUILD/config.status/config.status

OpenBSD60 amd64 build: Failed

Make failed for OpenBSD60 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244: error: 'struct route_node' has no member named 'aggregate'

OpenBSD60 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI011BUILD/config.status/config.status

Debian9 amd64 build: Failed

Debian9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI021BUILD/config.status/config.status
Make failed for Debian9 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

NetBSD7 amd64 build: Failed

Make failed for NetBSD7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229:8: error: 'struct route_node' has no member named 'aggregate'
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: 'struct route_node' has no member named 'aggregate'
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

NetBSD7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI012BUILD/config.status/config.status

Ubuntu1604 amd64 build: Failed

Make failed for Ubuntu1604 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

Ubuntu1604 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI014BUILD/config.status/config.status

FreeBSD11 amd64 build: Failed

Make failed for FreeBSD11 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229:8: error: 'struct route_node' has no member named 'aggregate'
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: 'struct route_node' has no member named 'aggregate'
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

FreeBSD11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI009BUILD/config.status/config.status

CentOS6 amd64 build: Failed

Make failed for CentOS6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI006BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:237: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:237: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:237: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:237: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:244: error: struct route_node has no member named aggregate
rfapi/rfapi_import.c:244: error: struct route_node has no member named aggregate

CentOS6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI006BUILD/config.status/config.status

NetBSD6 amd64 build: Failed

Make failed for NetBSD6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function 'rfapiCheckRefcount':
rfapi/rfapi_import.c:229:8: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:237:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244:15: error: 'struct route_node' has no member named 'aggregate'
rfapi/rfapi_import.c:244:15: error: 'struct route_node' has no member named 'aggregate'

NetBSD6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI007BUILD/config.status/config.status

Fedora24 amd64 build: Failed

Make failed for Fedora24 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI015BUILD/ErrorLog/log_make.txt)

  CC       rfapi/rfapi_import.o
rfapi/rfapi_import.c: In function rfapiCheckRefcount:
rfapi/rfapi_import.c:229:8: error: struct route_node has no member named aggregate
  if (rn->aggregate) {
        ^~
In file included from rfapi/rfapi_import.c:51:0:
../bgpd/rfapi/rfapi_monitor.h:122:7: error: struct route_node has no member named aggregate
  ((rn)->aggregate ? RFAPI_IT_EXTRA_GET(rn)->u.encap.e : NULL)
       ^

Fedora24 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4594/artifact/CI015BUILD/config.status/config.status

Report for ripngd.h
===============================================
< WARNING: function definition argument 'struct ripng_node *' should also have an identifier name
< #380: FILE: /tmp/f1-13344/ripngd.h:380:
< +extern void ripng_zebra_ipv6_add(struct ripng_node *);
< 
< WARNING: function definition argument 'struct ripng_node *' should also have an identifier name
< #381: FILE: /tmp/f1-13344/ripngd.h:381:
< +extern void ripng_zebra_ipv6_delete(struct ripng_node *);
---
Report for table.h
===============================================
> #126: FILE: /tmp/f2-13344/table.h:126:
61c72
< #123: FILE: /tmp/f1-13344/table.h:123:

NetDEF-CI · 2018-07-26T13:19:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Fedora24 amd64 build: Successful
Ubuntu1204 amd64 build: Successful
FreeBSD11 amd64 build: Successful
NetBSD6 amd64 build: Successful
OmniOS amd64 build: Successful
CentOS7 amd64 build: Successful
CentOS6 amd64 build: Successful
OpenBSD60 amd64 build: Successful
FreeBSD10 amd64 build: Successful
NetBSD7 amd64 build: Successful
FreeBSD9 amd64 build: Successful

Ubuntu1404 amd64 build: Failed

Package building failed for Ubuntu1404 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI001BUILD/ErrorLog/log_package_build.txt)

debian/rules:56: "DEBIAN: SNMP disabled, see README.Debian"
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
	dh_auto_configure -- \
		--enable-exampledir=/usr/share/doc/frr/examples/ \
		--localstatedir=/var/run/frr \
		--sbindir=/usr/lib/frr \

Ubuntu1404 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI001BUILD/config.status/config.status

Ubuntu1604 amd64 build: Failed

Ubuntu1604 amd64 build: Unknown Log <log_snapcraft.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI014BUILD/ErrorLog/log_snapcraft.txt
Ubuntu1604 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI014BUILD/config.status/config.status
Ubuntu1604 amd64 build: No useful log found

Ubuntu 18.04 amd64 build: Failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/U1804AMD64/config.status/config.status
Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \

Ubuntu 16.04 i386: Failed

Ubuntu 16.04 i386: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386: Unknown Log <log_snapcraft.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/U1604I386/ErrorLog/log_snapcraft.txt
Ubuntu 16.04 i386: No useful log found

Debian8 amd64 build: Failed

Package building failed for Debian8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI008BLD/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \

Debian8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI008BLD/config.status/config.status

Debian9 amd64 build: Failed

Debian9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI021BUILD/config.status/config.status
Package building failed for Debian9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI021BUILD/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Ubuntu1404 amd64 build: Failed

Package building failed for Ubuntu1404 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI001BUILD/ErrorLog/log_package_build.txt)

debian/rules:56: "DEBIAN: SNMP disabled, see README.Debian"
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
	dh_auto_configure -- \
		--enable-exampledir=/usr/share/doc/frr/examples/ \
		--localstatedir=/var/run/frr \
		--sbindir=/usr/lib/frr \

Ubuntu1404 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI001BUILD/config.status/config.status

Ubuntu1604 amd64 build: Failed

Ubuntu1604 amd64 build: Unknown Log <log_snapcraft.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI014BUILD/ErrorLog/log_snapcraft.txt
Ubuntu1604 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI014BUILD/config.status/config.status
Ubuntu1604 amd64 build: No useful log found

Ubuntu 18.04 amd64 build: Failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/U1804AMD64/config.status/config.status
Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \

Ubuntu 16.04 i386: Failed

Ubuntu 16.04 i386: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386: Unknown Log <log_snapcraft.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/U1604I386/ErrorLog/log_snapcraft.txt
Ubuntu 16.04 i386: No useful log found

Debian8 amd64 build: Failed

Package building failed for Debian8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI008BLD/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \

Debian8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI008BLD/config.status/config.status

Debian9 amd64 build: Failed

Debian9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI021BUILD/config.status/config.status
Package building failed for Debian9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4629/artifact/CI021BUILD/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \


Report for rfapi_rib.c
===============================================
> #1633: FILE: /tmp/f2-28218/rfapi_rib.c:1633:
188c194
< #1683: FILE: /tmp/f1-28218/rfapi_rib.c:1683:
Report for ripngd.h
===============================================
< WARNING: function definition argument 'struct ripng_node *' should also have an identifier name
< #380: FILE: /tmp/f1-28218/ripngd.h:380:
< +extern void ripng_zebra_ipv6_add(struct ripng_node *);
< 
< WARNING: function definition argument 'struct ripng_node *' should also have an identifier name
< #381: FILE: /tmp/f1-28218/ripngd.h:381:
< +extern void ripng_zebra_ipv6_delete(struct ripng_node *);
---
Report for table.h
===============================================
> #126: FILE: /tmp/f2-28218/table.h:126:
61c72
< #123: FILE: /tmp/f1-28218/table.h:123:

LabN-CI · 2018-07-26T13:19:55Z

🛑 Basic BGPD CI results: FAILURE

Results table

_	_
Result	FAILURE git merge/2715 `fd0b869` Crash -- 1 cores
Date	07/26/2018
Start	09:11:01
Finish	09:19:48
Run-Time	08:47
Total	745
Pass	744
Fail	1
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2018-07-26-09:11:01.txt
Log	autoscript-2018-07-26-09:11:43.log.bz2

For details, please contact louberger

The `void *aggregate` pointer in ROUTE_NODE_FIELDS is only used by ripngd and the bgp rfapi code. As such every single route_node in the system is paying the cost of keeping this pointer around and never using it. Follow the table.h design pattern in bgp_table.h and create a `struct ripng_node` and `struct rfapi_node` pointers that actually have this aggregate pointer and then provide rfapi and ripng specific struct route_node <-> struct rfapi/ripng_node translator functions. On a 64 bit system this should account for 8 bytes of data per route_node which is not insignificant considering a full bgp feed in both bgp and zebra, or evpn routes which make signficant usage of tables. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

LabN-CI · 2018-07-26T14:03:03Z

🛑 Basic BGPD CI results: FAILURE

Results table

_	_
Result	FAILURE git merge/2715 `5c8f5bf` Crash -- 1 cores
Date	07/26/2018
Start	09:54:08
Finish	10:02:55
Run-Time	08:47
Total	745
Pass	744
Fail	1
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2018-07-26-09:54:08.txt
Log	autoscript-2018-07-26-09:54:50.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-07-26T14:21:26Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4630/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Successful
IPv6 protocols on Ubuntu 14.04: Successful
Ubuntu 16.04 deb pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
Fedora 24 rpm pkg check: Successful
CentOS 6 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
Topology tests on Ubuntu 16.04 amd64: Successful
IPv4 protocols on Ubuntu 14.04: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Debian 9 deb pkg check: Successful
Static analyzer (clang): Successful

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-4630/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2018-07-26 15:54:37,011 ERROR: ******************************************************************************
2018-07-26 15:54:37,011 ERROR: Test Target Summary                                                  Pass Fail
2018-07-26 15:54:37,011 ERROR: ******************************************************************************
2018-07-26 15:54:37,012 ERROR: FILE: scripts/adjacencies.py
2018-07-26 15:54:37,012 ERROR: 8    r2     Core adjacencies up +90.21 secs                          0    1
2018-07-26 15:54:37,012 ERROR: 11   r4     Core adjacencies up                                      0    1
2018-07-26 15:54:37,012 ERROR: 14   r4     All adjacencies up                                       0    1
2018-07-26 15:54:37,012 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-07-26 15:54:37,014 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_adjacencies": 3 tests failed
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4630/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4630/artifact/TOPOI386/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-4630/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2018-07-26 15:54:37,011 ERROR: ******************************************************************************
2018-07-26 15:54:37,011 ERROR: Test Target Summary                                                  Pass Fail
2018-07-26 15:54:37,011 ERROR: ******************************************************************************
2018-07-26 15:54:37,012 ERROR: FILE: scripts/adjacencies.py
2018-07-26 15:54:37,012 ERROR: 8    r2     Core adjacencies up +90.21 secs                          0    1
2018-07-26 15:54:37,012 ERROR: 11   r4     Core adjacencies up                                      0    1
2018-07-26 15:54:37,012 ERROR: 14   r4     All adjacencies up                                       0    1
2018-07-26 15:54:37,012 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-07-26 15:54:37,014 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_adjacencies": 3 tests failed
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4630/artifact/TOPOI386/ErrorLog/log_topotests.txt

Report for rfapi_rib.c
===============================================
> #1633: FILE: /tmp/f2-12916/rfapi_rib.c:1633:
188c194
< #1683: FILE: /tmp/f1-12916/rfapi_rib.c:1683:
Report for ripngd.h
===============================================
< WARNING: function definition argument 'struct ripng_node *' should also have an identifier name
< #380: FILE: /tmp/f1-12916/ripngd.h:380:
< +extern void ripng_zebra_ipv6_add(struct ripng_node *);
< 
< WARNING: function definition argument 'struct ripng_node *' should also have an identifier name
< #381: FILE: /tmp/f1-12916/ripngd.h:381:
< +extern void ripng_zebra_ipv6_delete(struct ripng_node *);
---
Report for table.h
===============================================
> #126: FILE: /tmp/f2-12916/table.h:126:
61c72
< #123: FILE: /tmp/f1-12916/table.h:123:

CLANG Static Analyzer Summary

Github Pull Request 2715, comparing to Git base SHA c11b11d

No Changes in Static Analysis warnings compared to base

5 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4630/artifact/shared/static_analysis/index.html

louberger

breaks rfapi:
seen in labn CI:

#0 0x000000331ec324f5 in raise () from /lib64/libc.so.6
(gdb) #0 0x000000331ec324f5 in raise () from /lib64/libc.so.6
#1 0x000000331ec33cd5 in abort () from /lib64/libc.so.6
#2 0x00000000004e0055 in _zlog_assert_failed (
assertion=0x50986e "node->lock > 0", file=0x50985f "../lib/table.h",
line=235, function=0x5337c0 "route_unlock_node") at lib/log.c:710
#3 0x0000000000490b06 in route_unlock_node (node=)
at ../lib/table.h:235
#4 0x000000000049184d in rfapi_query (handle=0x16306c70, target=0x18c9ee4,
l2o=, ppNextHopEntry=)
at ../bgpd/rfapi/rfapi_table.h:46

NetDEF-CI · 2018-07-28T15:13:10Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4630/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for rfapi_rib.c
===============================================
> #1633: FILE: /tmp/f2-12916/rfapi_rib.c:1633:
188c194
< #1683: FILE: /tmp/f1-12916/rfapi_rib.c:1683:
Report for ripngd.h
===============================================
< WARNING: function definition argument 'struct ripng_node *' should also have an identifier name
< #380: FILE: /tmp/f1-12916/ripngd.h:380:
< +extern void ripng_zebra_ipv6_add(struct ripng_node *);
< 
< WARNING: function definition argument 'struct ripng_node *' should also have an identifier name
< #381: FILE: /tmp/f1-12916/ripngd.h:381:
< +extern void ripng_zebra_ipv6_delete(struct ripng_node *);
---
Report for table.h
===============================================
> #126: FILE: /tmp/f2-12916/table.h:126:
61c72
< #123: FILE: /tmp/f1-12916/table.h:123:

CLANG Static Analyzer Summary

Github Pull Request 2715, comparing to Git base SHA c11b11d

No Changes in Static Analysis warnings compared to base

5 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4630/artifact/shared/static_analysis/index.html

pguibert6WIND

LGTM.
abstraction right.

donaldsharp · 2018-08-03T12:37:50Z

Unfortunately this code is horribly broken. Hence the in progress label I put on it. I am attempting to rework this. Let me see if I can pound this out real quick.

rwestphal · 2018-08-06T23:51:52Z

It seems this PR was superseded by #2785. Should we close this?

donaldsharp commented Jul 25, 2018

View reviewed changes

donaldsharp force-pushed the aggregate branch from cb1eaf3 to fd0b869 Compare July 26, 2018 13:01

donaldsharp force-pushed the aggregate branch from fd0b869 to 5c8f5bf Compare July 26, 2018 13:22

louberger requested changes Jul 28, 2018

View reviewed changes

donaldsharp added the in progress label Jul 31, 2018

pguibert6WIND approved these changes Aug 3, 2018

View reviewed changes

donaldsharp closed this Aug 14, 2018

donaldsharp deleted the aggregate branch September 13, 2018 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib, ripnd: Isolate aggreagate pointer to using protocol #2715

lib, ripnd: Isolate aggreagate pointer to using protocol #2715

donaldsharp commented Jul 25, 2018

donaldsharp Jul 25, 2018

LabN-CI commented Jul 25, 2018

NetDEF-CI commented Jul 25, 2018

NetDEF-CI commented Jul 26, 2018

LabN-CI commented Jul 26, 2018

LabN-CI commented Jul 26, 2018

NetDEF-CI commented Jul 26, 2018

louberger left a comment

NetDEF-CI commented Jul 28, 2018

pguibert6WIND left a comment

donaldsharp commented Aug 3, 2018

rwestphal commented Aug 6, 2018

lib, ripnd: Isolate aggreagate pointer to using protocol #2715

lib, ripnd: Isolate aggreagate pointer to using protocol #2715

Conversation

donaldsharp commented Jul 25, 2018

donaldsharp Jul 25, 2018

Choose a reason for hiding this comment

LabN-CI commented Jul 25, 2018

🛑 Basic BGPD CI results: FAILURE

NetDEF-CI commented Jul 25, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

FreeBSD9 amd64 build: Failed

Ubuntu 16.04 i386: Failed

CentOS7 amd64 build: Failed

Ubuntu 18.04 amd64 build: Failed

FreeBSD10 amd64 build: Failed

Ubuntu1404 amd64 build: Failed

Debian8 amd64 build: Failed

OmniOS amd64 build: Failed

OpenBSD60 amd64 build: Failed

Debian9 amd64 build: Failed

NetBSD7 amd64 build: Failed

Ubuntu1604 amd64 build: Failed

FreeBSD11 amd64 build: Failed

CentOS6 amd64 build: Failed

NetBSD6 amd64 build: Failed

Fedora24 amd64 build: Failed

Warnings Generated during build:

Checkout code: Successful with additional warnings:

FreeBSD9 amd64 build: Failed

Ubuntu 16.04 i386: Failed

CentOS7 amd64 build: Failed

Ubuntu 18.04 amd64 build: Failed

FreeBSD10 amd64 build: Failed

Ubuntu1404 amd64 build: Failed

Debian8 amd64 build: Failed

OmniOS amd64 build: Failed

OpenBSD60 amd64 build: Failed

Debian9 amd64 build: Failed

NetBSD7 amd64 build: Failed

Ubuntu1604 amd64 build: Failed

FreeBSD11 amd64 build: Failed

CentOS6 amd64 build: Failed

NetBSD6 amd64 build: Failed

Fedora24 amd64 build: Failed

NetDEF-CI commented Jul 26, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1404 amd64 build: Failed

Ubuntu1604 amd64 build: Failed

Ubuntu 18.04 amd64 build: Failed

Ubuntu 16.04 i386: Failed

Debian8 amd64 build: Failed

Debian9 amd64 build: Failed

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Ubuntu1404 amd64 build: Failed

Ubuntu1604 amd64 build: Failed

Ubuntu 18.04 amd64 build: Failed

Ubuntu 16.04 i386: Failed

Debian8 amd64 build: Failed

Debian9 amd64 build: Failed

LabN-CI commented Jul 26, 2018

🛑 Basic BGPD CI results: FAILURE

LabN-CI commented Jul 26, 2018

🛑 Basic BGPD CI results: FAILURE

NetDEF-CI commented Jul 26, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4630/artifact/TOPOI386/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topotest tests on Ubuntu 16.04 i386: Failed

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base