Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some testing support for use in rfapi topotest #2934

Merged

Conversation

louberger
Copy link
Member

@louberger louberger commented Aug 28, 2018

to help donald run down issues in #2785
supports new topotest merged in FRRouting/topotests#128 and FRRouting/topotests#130

Signed-off-by: Lou Berger <lberger@labn.net>
@louberger louberger requested a review from donaldsharp August 28, 2018 19:24
@NetDEF-CI

This comment has been minimized.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 28, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/2934 b219688
Date 08/28/2018
Start 15:53:49
Finish 16:17:18
Run-Time 23:29
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-08-28-15:53:49.txt
Log autoscript-2018-08-28-15:54:34.log.bz2

For details, please contact louberger

Signed-off-by: Lou Berger <lberger@labn.net>
@louberger louberger force-pushed the working/master/rfapi_topotest_support branch from b219688 to 6a809ee Compare August 28, 2018 23:27
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 29, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/2934 6a809ee
Date 08/28/2018
Start 19:54:18
Finish 20:17:28
Run-Time 23:10
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-08-28-19:54:18.txt
Log autoscript-2018-08-28-19:55:04.log.bz2

For details, please contact louberger

@NetDEF-CI

This comment has been minimized.

@NetDEF-CI

This comment has been minimized.

Signed-off-by: Lou Berger <lberger@labn.net>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 29, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/2934 3a022a7
Date 08/29/2018
Start 09:30:33
Finish 09:53:42
Run-Time 23:09
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-08-29-09:30:33.txt
Log autoscript-2018-08-29-09:31:18.log.bz2

For details, please contact louberger

@NetDEF-CI

This comment has been minimized.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 29, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/2934 752a286
Date 08/29/2018
Start 11:10:32
Finish 11:33:38
Run-Time 23:06
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-08-29-11:10:32.txt
Log autoscript-2018-08-29-11:11:16.log.bz2

For details, please contact louberger

@NetDEF-CI

This comment has been minimized.

@louberger
Copy link
Member Author

suspect failure is from slow ci (now addressed in FRRouting/topotests#130 ) rerunning failed test to see if it reproduces

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5095/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 2934, comparing to Git base SHA 96487ee

No Changes in Static Analysis warnings compared to base

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5095/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5100/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 2934, comparing to Git base SHA 96487ee

Fixed warnings:

  • Memory error: Use-after-free in dpd/lde.c, function lde_address_list_free, line 1624
  • Memory error: Use-after-free in ib/imsg-buffer.c, function msgbuf_clear, line 199
  • Memory error: Use-after-free in ib/imsg.c, function imsg_get_fd, line 305
  • Logic error: Assigned value is garbage or undefined in ib/skiplist.c, function skiplist_insert, line 224

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 4
  • New warnings: 4

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5100/artifact/shared/static_analysis/index.html

@eqvinox eqvinox merged commit 6a314aa into FRRouting:master Sep 4, 2018
@louberger louberger deleted the working/master/rfapi_topotest_support branch March 15, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants