bgp large & extended community parse fixes #5409

qlyoung · 2019-11-22T00:55:26Z

Couple heap overflows and oob reads in community attribute parsing paths, fixed

This needs careful review ☕ 👀 🔍

Copy paste leads to invalid read of 1 byte off the heap when converting extended community attributes into strings. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

NetDEF-CI · 2019-11-22T01:10:42Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^
cc1: all warnings being treated as errors

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI008BLD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI009BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/DEB10BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_dump.o
  CC       bgpd/bgp_ecommunity.o
cc1: warnings being treated as errors
bgpd/bgp_ecommunity.c: In function 'ecommunity_ecom2str':
bgpd/bgp_ecommunity.c:647:6: error: unused variable 'first'
bgpd/bgp_ecommunity.c:645:6: error: unused variable 'str_pnt'
gmake[1]: *** [Makefile:7003: bgpd/bgp_ecommunity.o] Error 1
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI005BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
___________________________ TestEcommunity.test_asn4 ___________________________
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>, line = 'asn4'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'asn4' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
_______________________ TestEcommunity.test_exit_cleanly _______________________
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30f10>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>
    def _exit_cleanly(self):
        if self.exitcode != 0:
>           raise MultiTestFailure("Program did not terminate with exit code 0")
E           MultiTestFailure: Program did not terminate with exit code 0
helpers/python/frrtest.py:84: MultiTestFailure
___________________________ TestEcommunity.test_asn ____________________________
self = <test_ecommunity.TestEcommunity object at 0x7f3042d3a710>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>, line = 'asn'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'asn' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
________________________ TestEcommunity.test_ipaddr_so _________________________
self = <test_ecommunity.TestEcommunity object at 0x7f3042d3af90>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>
line = 'ipaddr-so'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI005BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI011BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^
cc1: all warnings being treated as errors

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^~~~~
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^~~~~~~
cc1: all warnings being treated as errors

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^~~~~
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^~~~~~~
  CC       bgpd/bgp_encap_tlv.o

NetBSD 7 amd64 build: Failed (click for details)

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^~~~~
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^~~~~~~
cc1: all warnings being treated as errors

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI021BUILD/config.status/config.status

Ubuntu 14.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^
cc1: all warnings being treated as errors

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI001BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/F29BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1604I386/config.status/config.status

Successful on other platforms

Ubuntu 12.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^
cc1: all warnings being treated as errors

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI008BLD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI009BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/DEB10BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_dump.o
  CC       bgpd/bgp_ecommunity.o
cc1: warnings being treated as errors
bgpd/bgp_ecommunity.c: In function 'ecommunity_ecom2str':
bgpd/bgp_ecommunity.c:647:6: error: unused variable 'first'
bgpd/bgp_ecommunity.c:645:6: error: unused variable 'str_pnt'
gmake[1]: *** [Makefile:7003: bgpd/bgp_ecommunity.o] Error 1
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI005BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
___________________________ TestEcommunity.test_asn4 ___________________________
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>, line = 'asn4'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'asn4' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
_______________________ TestEcommunity.test_exit_cleanly _______________________
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30f10>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>
    def _exit_cleanly(self):
        if self.exitcode != 0:
>           raise MultiTestFailure("Program did not terminate with exit code 0")
E           MultiTestFailure: Program did not terminate with exit code 0
helpers/python/frrtest.py:84: MultiTestFailure
___________________________ TestEcommunity.test_asn ____________________________
self = <test_ecommunity.TestEcommunity object at 0x7f3042d3a710>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>, line = 'asn'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'asn' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
________________________ TestEcommunity.test_ipaddr_so _________________________
self = <test_ecommunity.TestEcommunity object at 0x7f3042d3af90>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f3042d30250>
line = 'ipaddr-so'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI005BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI011BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^
cc1: all warnings being treated as errors

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^~~~~
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^~~~~~~
cc1: all warnings being treated as errors

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^~~~~
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^~~~~~~
  CC       bgpd/bgp_encap_tlv.o

NetBSD 7 amd64 build: Failed (click for details)

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^~~~~
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^~~~~~~
cc1: all warnings being treated as errors

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI021BUILD/config.status/config.status

Ubuntu 14.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^
cc1: all warnings being treated as errors

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/CI001BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/F29BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
bgpd/bgp_ecommunity.c: In function ecommunity_ecom2str:
bgpd/bgp_ecommunity.c:647:6: error: unused variable first [-Werror=unused-variable]
  int first = 1;
      ^
bgpd/bgp_ecommunity.c:645:6: error: unused variable str_pnt [-Werror=unused-variable]
  int str_pnt;
      ^
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9821/artifact/U1604I386/config.status/config.status

Report for bgp_ecommunity.c | 40 issues
===============================================
< WARNING: line over 80 characters
< #85: FILE: /tmp/f1-8954/bgp_ecommunity.c:85:
< WARNING: line over 80 characters
< #92: FILE: /tmp/f1-8954/bgp_ecommunity.c:92:
< WARNING: Missing a blank line after declarations
< #94: FILE: /tmp/f1-8954/bgp_ecommunity.c:94:
< WARNING: line over 80 characters
< #103: FILE: /tmp/f1-8954/bgp_ecommunity.c:103:
< WARNING: line over 80 characters
< #557: FILE: /tmp/f1-8954/bgp_ecommunity.c:557:
< WARNING: Missing a blank line after declarations
< #703: FILE: /tmp/f1-8954/bgp_ecommunity.c:703:
< WARNING: line over 80 characters
< #709: FILE: /tmp/f1-8954/bgp_ecommunity.c:709:
< WARNING: line over 80 characters
< #739: FILE: /tmp/f1-8954/bgp_ecommunity.c:739:
< WARNING: line over 80 characters
< #740: FILE: /tmp/f1-8954/bgp_ecommunity.c:740:
< WARNING: suspect code indent for conditional statements (32, 54)
< #744: FILE: /tmp/f1-8954/bgp_ecommunity.c:744:
< WARNING: line over 80 characters
< #745: FILE: /tmp/f1-8954/bgp_ecommunity.c:745:
< WARNING: line over 80 characters
< #761: FILE: /tmp/f1-8954/bgp_ecommunity.c:761:
< WARNING: Missing a blank line after declarations
< #761: FILE: /tmp/f1-8954/bgp_ecommunity.c:761:
< WARNING: line over 80 characters
< #763: FILE: /tmp/f1-8954/bgp_ecommunity.c:763:
< WARNING: line over 80 characters
< #775: FILE: /tmp/f1-8954/bgp_ecommunity.c:775:
< WARNING: line over 80 characters
< #777: FILE: /tmp/f1-8954/bgp_ecommunity.c:777:
< ERROR: space prohibited before that ',' (ctx:WxV)
< #777: FILE: /tmp/f1-8954/bgp_ecommunity.c:777:
< ERROR: space required after that ',' (ctx:WxV)
< #777: FILE: /tmp/f1-8954/bgp_ecommunity.c:777:
< WARNING: line over 80 characters
< #781: FILE: /tmp/f1-8954/bgp_ecommunity.c:781:
< WARNING: Missing a blank line after declarations
< #824: FILE: /tmp/f1-8954/bgp_ecommunity.c:824:
Report for bgp_lcommunity.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #213: FILE: /tmp/f1-8954/bgp_lcommunity.c:213:

LabN-CI · 2019-11-22T01:51:15Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	Complete
Date	11/15/2019
Start	20:25:21
Finish	20:49:31
Run-Time	24:10
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	autoscript-2019-11-15-20:25:21.txt
Log	autoscript-2019-11-15-20:25:21.log.bz2
Memory	396 432 360
SUCCESS git merge/5409 `0afbaad`	SUCCESS git merge/4794 `4e65208`
11/21/2019	08/06/2019
20:25:22	20:25:21
20:51:12	20:47:05
25:50	21:44
1815	1815
1815	1815
0	0
0	0
0	0
vncregress-2019-11-21-20:25:22.txt	vncregress-2019-08-06-20:25:21.txt
autoscript-2019-11-21-20:26:13.log.bz2	autoscript-2019-08-06-20:26:13.log.bz2
429 421 360	435 436 360

For details, please contact louberger

NetDEF-CI · 2019-11-22T06:22:03Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

NetBSD 6 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for NetBSD 6 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI007BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
___________________________ TestEcommunity.test_asn4 ___________________________
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>, line = 'asn4'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'asn4' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
_______________________ TestEcommunity.test_exit_cleanly _______________________
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578310>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>
    def _exit_cleanly(self):
        if self.exitcode != 0:
>           raise MultiTestFailure("Program did not terminate with exit code 0")
E           MultiTestFailure: Program did not terminate with exit code 0
helpers/python/frrtest.py:84: MultiTestFailure
___________________________ TestEcommunity.test_asn ____________________________
self = <test_ecommunity.TestEcommunity object at 0x7f7ff011f190>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>, line = 'asn'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'asn' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
________________________ TestEcommunity.test_ipaddr_so _________________________
self = <test_ecommunity.TestEcommunity object at 0x7f7ff092fcd0>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>
line = 'ipaddr-so'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI005BUILD/ErrorLog/log_pytests.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI005BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Debian 8 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI008BLD/ErrorLog/log_pytests.txt
Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI008BLD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/FBSD12AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 12 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/FBSD12AMD64/ErrorLog/log_pytests.txt

Ubuntu 14.04 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 14.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI001BUILD/ErrorLog/log_pytests.txt
Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI001BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI011BUILD/ErrorLog/log_pytests.txt
OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI011BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/DEB10BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 10 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/DEB10BUILD/ErrorLog/log_pytests.txt

NetBSD 7 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for NetBSD 7 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI012BUILD/ErrorLog/log_pytests.txt
NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 16.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI014BUILD/ErrorLog/log_pytests.txt
Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 18.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804AMD64/ErrorLog/log_pytests.txt
Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for FreeBSD 11 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI009BUILD/ErrorLog/log_pytests.txt
FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804PPC64LEBUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 ppc64le build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804PPC64LEBUILD/ErrorLog/log_pytests.txt

Debian 9 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Debian 9 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI021BUILD/ErrorLog/log_pytests.txt
Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI021BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 16.04 i386 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1604I386/ErrorLog/log_pytests.txt
Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/F29BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Fedora 29 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/F29BUILD/ErrorLog/log_pytests.txt

Successful on other platforms

Ubuntu 12.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

NetBSD 6 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for NetBSD 6 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI007BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
___________________________ TestEcommunity.test_asn4 ___________________________
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>, line = 'asn4'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'asn4' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
_______________________ TestEcommunity.test_exit_cleanly _______________________
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578310>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>
    def _exit_cleanly(self):
        if self.exitcode != 0:
>           raise MultiTestFailure("Program did not terminate with exit code 0")
E           MultiTestFailure: Program did not terminate with exit code 0
helpers/python/frrtest.py:84: MultiTestFailure
___________________________ TestEcommunity.test_asn ____________________________
self = <test_ecommunity.TestEcommunity object at 0x7f7ff011f190>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>, line = 'asn'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'asn' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
________________________ TestEcommunity.test_ipaddr_so _________________________
self = <test_ecommunity.TestEcommunity object at 0x7f7ff092fcd0>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_ecommunity.TestEcommunity object at 0x7f7ff0578210>
line = 'ipaddr-so'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI005BUILD/ErrorLog/log_pytests.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI005BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Debian 8 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI008BLD/ErrorLog/log_pytests.txt
Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI008BLD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/FBSD12AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 12 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/FBSD12AMD64/ErrorLog/log_pytests.txt

Ubuntu 14.04 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 14.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI001BUILD/ErrorLog/log_pytests.txt
Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI001BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI011BUILD/ErrorLog/log_pytests.txt
OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI011BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/DEB10BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 10 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/DEB10BUILD/ErrorLog/log_pytests.txt

NetBSD 7 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for NetBSD 7 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI012BUILD/ErrorLog/log_pytests.txt
NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 16.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI014BUILD/ErrorLog/log_pytests.txt
Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 18.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804AMD64/ErrorLog/log_pytests.txt
Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for FreeBSD 11 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI009BUILD/ErrorLog/log_pytests.txt
FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804PPC64LEBUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 ppc64le build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1804PPC64LEBUILD/ErrorLog/log_pytests.txt

Debian 9 amd64 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Debian 9 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI021BUILD/ErrorLog/log_pytests.txt
Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/CI021BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 16.04 i386 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1604I386/ErrorLog/log_pytests.txt
Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/F29BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Fedora 29 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9823/artifact/F29BUILD/ErrorLog/log_pytests.txt

Report for bgp_ecommunity.c | 40 issues
===============================================
< WARNING: line over 80 characters
< #85: FILE: /tmp/f1-9866/bgp_ecommunity.c:85:
< WARNING: line over 80 characters
< #92: FILE: /tmp/f1-9866/bgp_ecommunity.c:92:
< WARNING: Missing a blank line after declarations
< #94: FILE: /tmp/f1-9866/bgp_ecommunity.c:94:
< WARNING: line over 80 characters
< #103: FILE: /tmp/f1-9866/bgp_ecommunity.c:103:
< WARNING: line over 80 characters
< #557: FILE: /tmp/f1-9866/bgp_ecommunity.c:557:
< WARNING: Missing a blank line after declarations
< #701: FILE: /tmp/f1-9866/bgp_ecommunity.c:701:
< WARNING: line over 80 characters
< #707: FILE: /tmp/f1-9866/bgp_ecommunity.c:707:
< WARNING: line over 80 characters
< #737: FILE: /tmp/f1-9866/bgp_ecommunity.c:737:
< WARNING: line over 80 characters
< #738: FILE: /tmp/f1-9866/bgp_ecommunity.c:738:
< WARNING: suspect code indent for conditional statements (32, 54)
< #742: FILE: /tmp/f1-9866/bgp_ecommunity.c:742:
< WARNING: line over 80 characters
< #743: FILE: /tmp/f1-9866/bgp_ecommunity.c:743:
< WARNING: line over 80 characters
< #759: FILE: /tmp/f1-9866/bgp_ecommunity.c:759:
< WARNING: Missing a blank line after declarations
< #759: FILE: /tmp/f1-9866/bgp_ecommunity.c:759:
< WARNING: line over 80 characters
< #761: FILE: /tmp/f1-9866/bgp_ecommunity.c:761:
< WARNING: line over 80 characters
< #773: FILE: /tmp/f1-9866/bgp_ecommunity.c:773:
< WARNING: line over 80 characters
< #775: FILE: /tmp/f1-9866/bgp_ecommunity.c:775:
< ERROR: space prohibited before that ',' (ctx:WxV)
< #775: FILE: /tmp/f1-9866/bgp_ecommunity.c:775:
< ERROR: space required after that ',' (ctx:WxV)
< #775: FILE: /tmp/f1-9866/bgp_ecommunity.c:775:
< WARNING: line over 80 characters
< #779: FILE: /tmp/f1-9866/bgp_ecommunity.c:779:
< WARNING: Missing a blank line after declarations
< #822: FILE: /tmp/f1-9866/bgp_ecommunity.c:822:
Report for bgp_lcommunity.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #212: FILE: /tmp/f1-9866/bgp_lcommunity.c:212:

LabN-CI · 2019-11-22T06:56:16Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5409 `7b63725`
Date	11/22/2019
Start	01:30:23
Finish	01:56:14
Run-Time	25:51
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-11-22-01:30:23.txt
Log	autoscript-2019-11-22-01:31:17.log.bz2
Memory	425 413 360

For details, please contact louberger

bgpd/bgp_ecommunity.c

bgpd/bgp_lcommunity.c

Tons of insane just-so pointer math here where it is not needed. This is too smart. Use safer methods. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Spaces were not being accounted for in the heap buffer sizing, leading to a heap buffer overflow when encoding large communities to their string representations. This patch also uses safer functions to do the encoding instead of pointer math. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

LabN-CI · 2019-11-22T09:11:11Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5409 `73bfd76`
Date	11/22/2019
Start	03:45:22
Finish	04:11:08
Run-Time	25:46
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-11-22-03:45:22.txt
Log	autoscript-2019-11-22-03:46:17.log.bz2
Memory	432 435 360

For details, please contact louberger

NetDEF-CI · 2019-11-22T11:22:44Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9826/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_ecommunity.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #95: FILE: /tmp/f1-12880/bgp_ecommunity.c:95:
< WARNING: Missing a blank line after declarations
< #701: FILE: /tmp/f1-12880/bgp_ecommunity.c:701:
< WARNING: Missing a blank line after declarations
< #767: FILE: /tmp/f1-12880/bgp_ecommunity.c:767:
< WARNING: Missing a blank line after declarations
< #834: FILE: /tmp/f1-12880/bgp_ecommunity.c:834:
Report for bgp_lcommunity.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #212: FILE: /tmp/f1-12880/bgp_lcommunity.c:212:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9826/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191122-02-g73bfd76d6-0 (missing) -> 7.3-dev-20191122-02-g73bfd76d6-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191122-02-g73bfd76d6-0 (missing) -> 7.3-dev-20191122-02-g73bfd76d6-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191122-02-g73bfd76d6-0 (missing) -> 7.3-dev-20191122-02-g73bfd76d6-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191122-02-g73bfd76d6-0 (missing) -> 7.3-dev-20191122-02-g73bfd76d6-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191122-02-g73bfd76d6-0 (missing) -> 7.3-dev-20191122-02-g73bfd76d6-0~deb10u1

<TITLE>clang_check</TITLE>

clang_check

bgpd/bgp_ecommunity.c

ton31337

LGTM except those cosmetic warnings 👍

riw777

lgtm...

bgpd: remove extra ecom attr ptr increment

21c64e0

Copy paste leads to invalid read of 1 byte off the heap when converting extended community attributes into strings. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

polychaeta added the bgp label Nov 22, 2019

qlyoung force-pushed the bgpd-lcom-ecom-parse-fixes branch from 0afbaad to 7b63725 Compare November 22, 2019 06:04

ton31337 reviewed Nov 22, 2019

View reviewed changes

bgpd/bgp_ecommunity.c Outdated Show resolved Hide resolved

bgpd/bgp_lcommunity.c Outdated Show resolved Hide resolved

qlyoung added 2 commits November 22, 2019 03:26

bgpd: use safe functions to work with ecom attrs

91085f9

Tons of insane just-so pointer math here where it is not needed. This is too smart. Use safer methods. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

qlyoung force-pushed the bgpd-lcom-ecom-parse-fixes branch from 7b63725 to 73bfd76 Compare November 22, 2019 08:26

ton31337 reviewed Nov 22, 2019

View reviewed changes

bgpd/bgp_ecommunity.c Show resolved Hide resolved

ton31337 approved these changes Nov 26, 2019

View reviewed changes

riw777 approved these changes Nov 26, 2019

View reviewed changes

eqvinox merged commit 6fc3fed into FRRouting:master Nov 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bgp large & extended community parse fixes #5409

bgp large & extended community parse fixes #5409

qlyoung commented Nov 22, 2019 •

edited

Loading

NetDEF-CI commented Nov 22, 2019

LabN-CI commented Nov 22, 2019

NetDEF-CI commented Nov 22, 2019

LabN-CI commented Nov 22, 2019

LabN-CI commented Nov 22, 2019

NetDEF-CI commented Nov 22, 2019

ton31337 left a comment

riw777 left a comment

bgp large & extended community parse fixes #5409

bgp large & extended community parse fixes #5409

Conversation

qlyoung commented Nov 22, 2019 • edited Loading

NetDEF-CI commented Nov 22, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Nov 22, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 22, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Nov 22, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Nov 22, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 22, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

clang_check

ton31337 left a comment

Choose a reason for hiding this comment

riw777 left a comment

Choose a reason for hiding this comment

qlyoung commented Nov 22, 2019 •

edited

Loading