Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtysh: fix ldpd vtysh #559

Closed
wants to merge 1 commit into from
Closed

Conversation

qlyoung
Copy link
Member

@qlyoung qlyoung commented May 17, 2017

ldpd needs a special case to execute the correct exit command for walkup
when using vtysh

fix #25

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

ldpd needs a special case to execute the correct exit command for walkup
when using vtysh

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
@qlyoung qlyoung requested a review from rwestphal May 17, 2017 01:55
@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-730/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@rwestphal
Copy link
Member

Thanks Quentin!

I confirm it fixes #25.

A few notes though:
1 - We need the same fix for stable/3.0;

2 - I just realized we have a similar problem with the LDP interface node when trying to copy and paste the running configuration:

debian(config)# do sh run
Building configuration...

Current configuration:
!
[snip]
!
mpls ldp
 router-id 1.1.1.1
 neighbor 2.2.2.2 password opensourcerouting
 neighbor 3.3.3.3 password opensourcerouting
 neighbor 4.4.4.4 password opensourcerouting
 !
 address-family ipv4
  discovery transport-address 1.1.1.1
  !
  interface rt1-eth1
  !
  interface rt1-eth2
  !
 !
!
l2vpn CUST_A type vpls
 bridge rt1-br0
 member interface rt1-eth0
 !
 member pseudowire rt1-mpw0
  neighbor lsr-id 2.2.2.2
  pw-id 100
 !
 member pseudowire rt1-mpw1
  neighbor lsr-id 3.3.3.3
  pw-id 100
 !
 member pseudowire rt1-mpw2
  neighbor lsr-id 4.4.4.4
  pw-id 100
 !
!
line vty
!
end
debian(config)#
debian(config)# mpls ldp
debian(config-ldp)#  router-id 1.1.1.1
debian(config-ldp)#  neighbor 2.2.2.2 password opensourcerouting
debian(config-ldp)#  neighbor 3.3.3.3 password opensourcerouting
debian(config-ldp)#  neighbor 4.4.4.4 password opensourcerouting
debian(config-ldp)#  !
debian(config-ldp)#  address-family ipv4
debian(config-ldp-af)#   discovery transport-address 1.1.1.1
debian(config-ldp-af)#   !
debian(config-ldp-af)#   interface rt1-eth1
debian(config-ldp-af-if)#   !
debian(config-ldp-af-if)#   interface rt1-eth2
% [LDP] Unknown command:   interface rt1-eth2
debian(config)#   !
debian(config)#  !
debian(config)# !
debian(config)# l2vpn CUST_A type vpls
debian(config-l2vpn)#  bridge rt1-br0
debian(config-l2vpn)#  member interface rt1-eth0
debian(config-l2vpn)#  !
debian(config-l2vpn)#  member pseudowire rt1-mpw0
debian(config-l2vpn-pw)#   neighbor lsr-id 2.2.2.2
debian(config-l2vpn-pw)#   pw-id 100
debian(config-l2vpn-pw)#  !
debian(config-l2vpn-pw)#  member pseudowire rt1-mpw1
debian(config-l2vpn-pw)#   neighbor lsr-id 3.3.3.3
debian(config-l2vpn-pw)#   pw-id 100
debian(config-l2vpn-pw)#  !
debian(config-l2vpn-pw)#  member pseudowire rt1-mpw2
debian(config-l2vpn-pw)#   neighbor lsr-id 4.4.4.4
debian(config-l2vpn-pw)#   pw-id 100
debian(config-l2vpn-pw)#  !
debian(config-l2vpn-pw)# !
debian(config-l2vpn-pw)#

Can you take a look at this for me?

I think the fix should be similar, but this time for LDP_IPV4_IFACE_NODE and LDP_IPV6_IFACE_NODE.

@qlyoung qlyoung mentioned this pull request May 17, 2017
@qlyoung
Copy link
Member Author

qlyoung commented May 17, 2017

see #565

@qlyoung qlyoung closed this May 17, 2017
@qlyoung qlyoung deleted the fix-ldpd-vtysh branch May 17, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ldpd: problem trying to copy & paste l2vpn config using vtysh
3 participants