Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yang: add vrf ref to interface model #5751

Merged
merged 1 commit into from
Feb 5, 2020
Merged

yang: add vrf ref to interface model #5751

merged 1 commit into from
Feb 5, 2020

Conversation

chiragshah6
Copy link
Member 

module: frr-interface
  +--rw lib
     +--rw interface* [name vrf]
        +--rw name           string
        +--rw vrf            frr-vrf:vrf-ref
        +--rw description?   string

Signed-off-by: Chirag Shah chirag@cumulusnetworks.com

@polychaeta polychaeta added the yang label Feb 3, 2020
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10592/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10592/artifact/CI009BUILD/ErrorLog/log_make.txt)

 9595 |    CPP_NOTICE(
ospfd/ospf_neighbor.c: In function 'ospf_nbr_lookup':
ospfd/ospf_neighbor.c:410:45: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7471: ospfd/ospf_neighbor.o] Error 1
In file included from ./lib/yang_wrappers.h:23,
eigrpd/eigrp_packet.c: In function 'eigrp_read':
eigrpd/eigrp_packet.c:552:25: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
./lib/prefix.h:344:46: note: in definition of macro 'IPV4_ADDR_SAME'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10592/artifact/CI009BUILD/config.status/config.status

Successful on other platforms
  • NetBSD 6 amd64 build
  • CentOS 7 amd64 build
  • Debian 10 amd64 build
  • Debian 8 amd64 build
  • Ubuntu 14.04 amd64 build
  • FreeBSD 12 amd64 build
  • OpenBSD 6 amd64 build
  • NetBSD 8 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 12.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 16.04 i386 build
  • Fedora 29 amd64 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10592/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1

rwestphal
rwestphal approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwestphal
Copy link
Member

CI:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10593/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10593/artifact/CI009BUILD/ErrorLog/log_make.txt)

 9595 |    CPP_NOTICE(
ospfd/ospf_neighbor.c: In function 'ospf_nbr_lookup':
ospfd/ospf_neighbor.c:410:45: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7471: ospfd/ospf_neighbor.o] Error 1
In file included from ./lib/yang_wrappers.h:23,
eigrpd/eigrp_packet.c: In function 'eigrp_read':
eigrpd/eigrp_packet.c:552:25: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
./lib/prefix.h:344:46: note: in definition of macro 'IPV4_ADDR_SAME'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10593/artifact/CI009BUILD/config.status/config.status

Successful on other platforms
  • CentOS 7 amd64 build
  • Ubuntu 14.04 amd64 build
  • Debian 10 amd64 build
  • Debian 8 amd64 build
  • FreeBSD 12 amd64 build
  • OpenBSD 6 amd64 build
  • NetBSD 8 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 amd64 build
  • NetBSD 6 amd64 build
  • Ubuntu 12.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Fedora 29 amd64 build
  • Ubuntu 16.04 i386 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10593/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1

@Spantik
Copy link
Member

Spantik commented Feb 4, 2020

CI:rerun

I think I need to rebase the branch. It is 400+ commit behind master and many yang PR are failing. I will do that today.

@qlyoung qlyoung self-requested a review February 4, 2020 16:21
@qlyoung
Copy link
Member

qlyoung commented Feb 4, 2020

@chiragshah6 we're going to rebase nb_conversions today; after that, please rebase this branch against it so we can pass CI

@chiragshah6
yang: add vrf ref to interface model
87ee53f 
module: frr-interface
  +--rw lib
     +--rw interface* [name vrf]
        +--rw name           string
        +--rw vrf            frr-vrf:vrf-ref
        +--rw description?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10613/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10613/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1

@rwestphal rwestphal merged commit 5dd164b into FRRouting:nb_conversions Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlyoung qlyoung qlyoung approved these changes

@rwestphal rwestphal rwestphal approved these changes

Assignees
No one assigned
Labels
yang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chiragshah6 @NetDEF-CI @rwestphal @Spantik @qlyoung @polychaeta