zebra: srv6 manager #5865
Merged
zebra: srv6 manager #5865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polychaeta
reviewed
Feb 26, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/976c3248882c04d672e5fb73df5a388a/raw/5370987b100fec15f3ea5cf0f24e8688b3a0eec3/cr_5865_1582699442.diff | git apply
diff --git a/lib/command.h b/lib/command.h
index 31b3ac0b8..2c82160fb 100644
--- a/lib/command.h
+++ b/lib/command.h
@@ -84,87 +84,87 @@ struct host {
/* List of CLI nodes. Please remember to update the name array in command.c. */
enum node_type {
- AUTH_NODE, /* Authentication mode of vty interface. */
- VIEW_NODE, /* View node. Default mode of vty interface. */
- AUTH_ENABLE_NODE, /* Authentication mode for change enable. */
- ENABLE_NODE, /* Enable node. */
- CONFIG_NODE, /* Config node. Default mode of config file. */
- DEBUG_NODE, /* Debug node. */
- VRF_DEBUG_NODE, /* Vrf Debug node. */
- NORTHBOUND_DEBUG_NODE, /* Northbound Debug node. */
- DEBUG_VNC_NODE, /* Debug VNC node. */
- RMAP_DEBUG_NODE, /* Route-map debug node */
- RESOLVER_DEBUG_NODE, /* Resolver debug node */
- AAA_NODE, /* AAA node. */
- KEYCHAIN_NODE, /* Key-chain node. */
- KEYCHAIN_KEY_NODE, /* Key-chain key node. */
- IP_NODE, /* Static ip route node. */
- VRF_NODE, /* VRF mode node. */
- INTERFACE_NODE, /* Interface mode node. */
- NH_GROUP_NODE, /* Nexthop-Group mode node. */
- ZEBRA_NODE, /* zebra connection node. */
- TABLE_NODE, /* rtm_table selection node. */
- RIP_NODE, /* RIP protocol mode node. */
- RIPNG_NODE, /* RIPng protocol mode node. */
- BABEL_NODE, /* BABEL protocol mode node. */
- EIGRP_NODE, /* EIGRP protocol mode node. */
- BGP_NODE, /* BGP protocol mode which includes BGP4+ */
- BGP_VPNV4_NODE, /* BGP MPLS-VPN PE exchange. */
- BGP_VPNV6_NODE, /* BGP MPLS-VPN PE exchange. */
- BGP_IPV4_NODE, /* BGP IPv4 unicast address family. */
- BGP_IPV4M_NODE, /* BGP IPv4 multicast address family. */
- BGP_IPV4L_NODE, /* BGP IPv4 labeled unicast address family. */
- BGP_IPV6_NODE, /* BGP IPv6 address family */
- BGP_IPV6M_NODE, /* BGP IPv6 multicast address family. */
- BGP_IPV6L_NODE, /* BGP IPv6 labeled unicast address family. */
- BGP_VRF_POLICY_NODE, /* BGP VRF policy */
- BGP_VNC_DEFAULTS_NODE, /* BGP VNC nve defaults */
- BGP_VNC_NVE_GROUP_NODE, /* BGP VNC nve group */
- BGP_VNC_L2_GROUP_NODE, /* BGP VNC L2 group */
- RFP_DEFAULTS_NODE, /* RFP defaults node */
- BGP_EVPN_NODE, /* BGP EVPN node. */
- OSPF_NODE, /* OSPF protocol mode */
- OSPF6_NODE, /* OSPF protocol for IPv6 mode */
- LDP_NODE, /* LDP protocol mode */
- LDP_IPV4_NODE, /* LDP IPv4 address family */
- LDP_IPV6_NODE, /* LDP IPv6 address family */
- LDP_IPV4_IFACE_NODE, /* LDP IPv4 Interface */
- LDP_IPV6_IFACE_NODE, /* LDP IPv6 Interface */
- LDP_L2VPN_NODE, /* LDP L2VPN node */
- LDP_PSEUDOWIRE_NODE, /* LDP Pseudowire node */
- ISIS_NODE, /* ISIS protocol mode */
- ACCESS_NODE, /* Access list node. */
- PREFIX_NODE, /* Prefix list node. */
- ACCESS_IPV6_NODE, /* Access list node. */
- ACCESS_MAC_NODE, /* MAC access list node*/
- PREFIX_IPV6_NODE, /* Prefix list node. */
- AS_LIST_NODE, /* AS list node. */
- COMMUNITY_LIST_NODE, /* Community list node. */
- RMAP_NODE, /* Route map node. */
- PBRMAP_NODE, /* PBR map node. */
- SMUX_NODE, /* SNMP configuration node. */
- DUMP_NODE, /* Packet dump node. */
- FORWARDING_NODE, /* IP forwarding node. */
- PROTOCOL_NODE, /* protocol filtering node */
- MPLS_NODE, /* MPLS config node */
- SR_NODE, /* SR node */
- SRV6_NODE, /* SRv6 node */
- SRV6_LOCS_NODE, /* SRv6 locators node */
- SRV6_LOC_NODE, /* SRv6 locator node */
- PW_NODE, /* Pseudowire config node */
- VTY_NODE, /* Vty node. */
- LINK_PARAMS_NODE, /* Link-parameters node */
- BGP_EVPN_VNI_NODE, /* BGP EVPN VNI */
- RPKI_NODE, /* RPKI node for configuration of RPKI cache server
- connections.*/
- BGP_FLOWSPECV4_NODE, /* BGP IPv4 FLOWSPEC Address-Family */
- BGP_FLOWSPECV6_NODE, /* BGP IPv6 FLOWSPEC Address-Family */
- BFD_NODE, /* BFD protocol mode. */
- BFD_PEER_NODE, /* BFD peer configuration mode. */
- OPENFABRIC_NODE, /* OpenFabric router configuration node */
- VRRP_NODE, /* VRRP node */
- BMP_NODE, /* BMP config under router bgp */
- NODE_TYPE_MAX, /* maximum */
+ AUTH_NODE, /* Authentication mode of vty interface. */
+ VIEW_NODE, /* View node. Default mode of vty interface. */
+ AUTH_ENABLE_NODE, /* Authentication mode for change enable. */
+ ENABLE_NODE, /* Enable node. */
+ CONFIG_NODE, /* Config node. Default mode of config file. */
+ DEBUG_NODE, /* Debug node. */
+ VRF_DEBUG_NODE, /* Vrf Debug node. */
+ NORTHBOUND_DEBUG_NODE, /* Northbound Debug node. */
+ DEBUG_VNC_NODE, /* Debug VNC node. */
+ RMAP_DEBUG_NODE, /* Route-map debug node */
+ RESOLVER_DEBUG_NODE, /* Resolver debug node */
+ AAA_NODE, /* AAA node. */
+ KEYCHAIN_NODE, /* Key-chain node. */
+ KEYCHAIN_KEY_NODE, /* Key-chain key node. */
+ IP_NODE, /* Static ip route node. */
+ VRF_NODE, /* VRF mode node. */
+ INTERFACE_NODE, /* Interface mode node. */
+ NH_GROUP_NODE, /* Nexthop-Group mode node. */
+ ZEBRA_NODE, /* zebra connection node. */
+ TABLE_NODE, /* rtm_table selection node. */
+ RIP_NODE, /* RIP protocol mode node. */
+ RIPNG_NODE, /* RIPng protocol mode node. */
+ BABEL_NODE, /* BABEL protocol mode node. */
+ EIGRP_NODE, /* EIGRP protocol mode node. */
+ BGP_NODE, /* BGP protocol mode which includes BGP4+ */
+ BGP_VPNV4_NODE, /* BGP MPLS-VPN PE exchange. */
+ BGP_VPNV6_NODE, /* BGP MPLS-VPN PE exchange. */
+ BGP_IPV4_NODE, /* BGP IPv4 unicast address family. */
+ BGP_IPV4M_NODE, /* BGP IPv4 multicast address family. */
+ BGP_IPV4L_NODE, /* BGP IPv4 labeled unicast address family. */
+ BGP_IPV6_NODE, /* BGP IPv6 address family */
+ BGP_IPV6M_NODE, /* BGP IPv6 multicast address family. */
+ BGP_IPV6L_NODE, /* BGP IPv6 labeled unicast address family. */
+ BGP_VRF_POLICY_NODE, /* BGP VRF policy */
+ BGP_VNC_DEFAULTS_NODE, /* BGP VNC nve defaults */
+ BGP_VNC_NVE_GROUP_NODE, /* BGP VNC nve group */
+ BGP_VNC_L2_GROUP_NODE, /* BGP VNC L2 group */
+ RFP_DEFAULTS_NODE, /* RFP defaults node */
+ BGP_EVPN_NODE, /* BGP EVPN node. */
+ OSPF_NODE, /* OSPF protocol mode */
+ OSPF6_NODE, /* OSPF protocol for IPv6 mode */
+ LDP_NODE, /* LDP protocol mode */
+ LDP_IPV4_NODE, /* LDP IPv4 address family */
+ LDP_IPV6_NODE, /* LDP IPv6 address family */
+ LDP_IPV4_IFACE_NODE, /* LDP IPv4 Interface */
+ LDP_IPV6_IFACE_NODE, /* LDP IPv6 Interface */
+ LDP_L2VPN_NODE, /* LDP L2VPN node */
+ LDP_PSEUDOWIRE_NODE, /* LDP Pseudowire node */
+ ISIS_NODE, /* ISIS protocol mode */
+ ACCESS_NODE, /* Access list node. */
+ PREFIX_NODE, /* Prefix list node. */
+ ACCESS_IPV6_NODE, /* Access list node. */
+ ACCESS_MAC_NODE, /* MAC access list node*/
+ PREFIX_IPV6_NODE, /* Prefix list node. */
+ AS_LIST_NODE, /* AS list node. */
+ COMMUNITY_LIST_NODE, /* Community list node. */
+ RMAP_NODE, /* Route map node. */
+ PBRMAP_NODE, /* PBR map node. */
+ SMUX_NODE, /* SNMP configuration node. */
+ DUMP_NODE, /* Packet dump node. */
+ FORWARDING_NODE, /* IP forwarding node. */
+ PROTOCOL_NODE, /* protocol filtering node */
+ MPLS_NODE, /* MPLS config node */
+ SR_NODE, /* SR node */
+ SRV6_NODE, /* SRv6 node */
+ SRV6_LOCS_NODE, /* SRv6 locators node */
+ SRV6_LOC_NODE, /* SRv6 locator node */
+ PW_NODE, /* Pseudowire config node */
+ VTY_NODE, /* Vty node. */
+ LINK_PARAMS_NODE, /* Link-parameters node */
+ BGP_EVPN_VNI_NODE, /* BGP EVPN VNI */
+ RPKI_NODE, /* RPKI node for configuration of RPKI cache server
+ connections.*/
+ BGP_FLOWSPECV4_NODE, /* BGP IPv4 FLOWSPEC Address-Family */
+ BGP_FLOWSPECV6_NODE, /* BGP IPv6 FLOWSPEC Address-Family */
+ BFD_NODE, /* BFD protocol mode. */
+ BFD_PEER_NODE, /* BFD peer configuration mode. */
+ OPENFABRIC_NODE, /* OpenFabric router configuration node */
+ VRRP_NODE, /* VRRP node */
+ BMP_NODE, /* BMP config under router bgp */
+ NODE_TYPE_MAX, /* maximum */
};
extern vector cmdvec;
diff --git a/lib/nexthop.c b/lib/nexthop.c
index 580105b0b..db048fbca 100644
--- a/lib/nexthop.c
+++ b/lib/nexthop.c
@@ -425,8 +425,8 @@ void nexthop_del_labels(struct nexthop *nexthop)
}
}
-void nexthop_add_seg6(struct nexthop *nexthop, int mode,
- size_t num_segs, struct in6_addr *segs)
+void nexthop_add_seg6(struct nexthop *nexthop, int mode, size_t num_segs,
+ struct in6_addr *segs)
{
struct seg6_segs *nh_segs;
@@ -445,8 +445,8 @@ void nexthop_del_seg6(struct nexthop *nexthop)
}
}
-void nexthop_add_seg6local(struct nexthop *nexthop,
- uint32_t action, const struct seg6local_context *ctx)
+void nexthop_add_seg6local(struct nexthop *nexthop, uint32_t action,
+ const struct seg6local_context *ctx)
{
struct seg6local_context *nh_ctx;
@@ -649,8 +649,7 @@ void nexthop_copy_no_recurse(struct nexthop *copy,
&nexthop->nh_seg6_segs->segs[0]);
if (nexthop->nh_seg6local_ctx) {
- nexthop_add_seg6local(copy,
- nexthop->nh_seg6local_action,
+ nexthop_add_seg6local(copy, nexthop->nh_seg6local_action,
nexthop->nh_seg6local_ctx);
}
}
diff --git a/lib/nexthop.h b/lib/nexthop.h
index 17780ef96..caf8258f1 100644
--- a/lib/nexthop.h
+++ b/lib/nexthop.h
@@ -135,8 +135,8 @@ void nexthops_free(struct nexthop *nexthop);
void nexthop_add_labels(struct nexthop *, enum lsp_types_t, uint8_t,
mpls_label_t *);
void nexthop_del_labels(struct nexthop *);
-void nexthop_add_seg6(struct nexthop *nexthop, int mode,
- size_t num_segs, struct in6_addr *segs);
+void nexthop_add_seg6(struct nexthop *nexthop, int mode, size_t num_segs,
+ struct in6_addr *segs);
void nexthop_del_seg6(struct nexthop *nexthop);
void nexthop_add_seg6local(struct nexthop *nexthop, uint32_t action,
const struct seg6local_context *ctx);
diff --git a/lib/srv6.c b/lib/srv6.c
index 0859325d5..e78a0ab1a 100644
--- a/lib/srv6.c
+++ b/lib/srv6.c
@@ -84,7 +84,8 @@ int snprintf_seg6_segs(char *str,
}
const char *seg6local_context2str(char *str, size_t size,
- const struct seg6local_context *ctx, uint32_t action)
+ const struct seg6local_context *ctx,
+ uint32_t action)
{
char b0[128];
@@ -159,8 +160,8 @@ struct srv6_function *srv6_function_alloc(const struct prefix_ipv6 *prefix)
}
void srv6_function_init(struct srv6_function *function,
- const char *locator_name,
- const struct prefix_ipv6 *prefix)
+ const char *locator_name,
+ const struct prefix_ipv6 *prefix)
{
memset(function, 0, sizeof(*function));
function->prefix.family = AF_INET6;
diff --git a/lib/srv6.h b/lib/srv6.h
index e6d1bcd04..ac1963630 100644
--- a/lib/srv6.h
+++ b/lib/srv6.h
@@ -148,21 +148,21 @@ static inline void *sid_copy(struct in6_addr *dst,
const char *
seg6local_action2str(uint32_t action);
-const char *
-seg6local_context2str(char *str, size_t size,
- const struct seg6local_context *ctx, uint32_t action);
+const char *seg6local_context2str(char *str, size_t size,
+ const struct seg6local_context *ctx,
+ uint32_t action);
int snprintf_seg6_segs(char *str,
size_t size, const struct seg6_segs *segs);
extern struct srv6_locator *srv6_locator_alloc(const char *name);
extern void srv6_locator_free(struct srv6_locator *locator);
-extern struct srv6_function *srv6_function_alloc(
- const struct prefix_ipv6 *prefix);
+extern struct srv6_function *
+srv6_function_alloc(const struct prefix_ipv6 *prefix);
extern void srv6_function_free(struct srv6_function *function);
extern void srv6_function_init(struct srv6_function *function,
- const char *locator_name,
- const struct prefix_ipv6 *prefix);
+ const char *locator_name,
+ const struct prefix_ipv6 *prefix);
#ifdef __cplusplus
}
diff --git a/lib/zclient.c b/lib/zclient.c
index 1b26ed054..90c7eeba7 100644
--- a/lib/zclient.c
+++ b/lib/zclient.c
@@ -3181,8 +3181,8 @@ static int zclient_read(struct thread *thread)
break;
case ZEBRA_SRV6_LOCATOR_ADD:
if (zclient->srv6_locator_add)
- (*zclient->srv6_locator_add)(command, zclient,
- length, vrf_id);
+ (*zclient->srv6_locator_add)(command, zclient, length,
+ vrf_id);
break;
case ZEBRA_SRV6_LOCATOR_DELETE:
if (zclient->srv6_locator_delete)
@@ -3191,8 +3191,8 @@ static int zclient_read(struct thread *thread)
break;
case ZEBRA_SRV6_FUNCTION_ADD:
if (zclient->srv6_function_add)
- (*zclient->srv6_function_add)(command, zclient,
- length, vrf_id);
+ (*zclient->srv6_function_add)(command, zclient, length,
+ vrf_id);
break;
case ZEBRA_SRV6_FUNCTION_DELETE:
if (zclient->srv6_function_delete)
@@ -3448,8 +3448,7 @@ int zapi_srv6_function_encode(uint8_t cmd, struct stream *s,
return 0;
}
-int zapi_srv6_function_decode(struct stream *s,
- struct srv6_function *function)
+int zapi_srv6_function_decode(struct stream *s, struct srv6_function *function)
{
uint8_t namelen;
diff --git a/lib/zclient.h b/lib/zclient.h
index c27eddd54..f7443418d 100644
--- a/lib/zclient.h
+++ b/lib/zclient.h
@@ -451,12 +451,12 @@ struct zapi_route {
* This flag tells Zebra that the route is a seg6 route and should
* be treated specially.
*/
-#define ZEBRA_FLAG_SEG6_ROUTE 0x80
+#define ZEBRA_FLAG_SEG6_ROUTE 0x80
/*
* This flag tells Zebra that the route is a seg6local route and
* should be treated specially.
*/
-#define ZEBRA_FLAG_SEG6LOCAL_ROUTE 0x100
+#define ZEBRA_FLAG_SEG6LOCAL_ROUTE 0x100
uint8_t message;
diff --git a/vtysh/vtysh.c b/vtysh/vtysh.c
index 6c296328c..eae4703dd 100644
--- a/vtysh/vtysh.c
+++ b/vtysh/vtysh.c
@@ -1206,19 +1206,23 @@ static struct cmd_node nh_group_node = {
};
static struct cmd_node sr_node = {
- SR_NODE, "%s(config-sr)# ",
+ SR_NODE,
+ "%s(config-sr)# ",
};
static struct cmd_node srv6_node = {
- SRV6_NODE, "%s(config-srv6)# ",
+ SRV6_NODE,
+ "%s(config-srv6)# ",
};
static struct cmd_node srv6_locs_node = {
- SRV6_LOCS_NODE, "%s(config-srv6-locators)# ",
+ SRV6_LOCS_NODE,
+ "%s(config-srv6-locators)# ",
};
static struct cmd_node srv6_loc_node = {
- SRV6_LOC_NODE, "%s(config-srv6-locator)# ",
+ SRV6_LOC_NODE,
+ "%s(config-srv6-locator)# ",
};
static struct cmd_node rmap_node = {RMAP_NODE, "%s(config-route-map)# "};
@@ -1351,32 +1355,27 @@ DEFUNSH(VTYSH_REALLYALL, vtysh_end_all, vtysh_end_all_cmd, "end",
return vtysh_end();
}
-DEFUNSH(VTYSH_SR, segment_routing, segment_routing_cmd,
- "segment-routing",
+DEFUNSH(VTYSH_SR, segment_routing, segment_routing_cmd, "segment-routing",
"Segment-Routing configration\n")
{
vty->node = SR_NODE;
return CMD_SUCCESS;
}
-DEFUNSH(VTYSH_SR, srv6, srv6_cmd,
- "srv6",
- "Segment-Routing SRv6 configration\n")
+DEFUNSH(VTYSH_SR, srv6, srv6_cmd, "srv6", "Segment-Routing SRv6 configration\n")
{
vty->node = SRV6_NODE;
return CMD_SUCCESS;
}
-DEFUNSH(VTYSH_SR, srv6_locators, srv6_locators_cmd,
- "locators",
+DEFUNSH(VTYSH_SR, srv6_locators, srv6_locators_cmd, "locators",
"Segment-Routing SRv6 locators configration\n")
{
vty->node = SRV6_LOCS_NODE;
return CMD_SUCCESS;
}
-DEFUNSH(VTYSH_SR, srv6_locator, srv6_locator_cmd,
- "locator WORD",
+DEFUNSH(VTYSH_SR, srv6_locator, srv6_locator_cmd, "locator WORD",
"Segment Routing SRv6 locator\n"
"Specify locator-name\n")
{
diff --git a/vtysh/vtysh.h b/vtysh/vtysh.h
index 3cac68296..bfea7f3b7 100644
--- a/vtysh/vtysh.h
+++ b/vtysh/vtysh.h
@@ -58,7 +58,7 @@ DECLARE_MGROUP(MVTYSH)
#define VTYSH_KEYS VTYSH_RIPD|VTYSH_EIGRPD
/* Daemons who can process nexthop-group configs */
#define VTYSH_NH_GROUP VTYSH_PBRD|VTYSH_SHARPD
-#define VTYSH_SR VTYSH_ZEBRA
+#define VTYSH_SR VTYSH_ZEBRA
enum vtysh_write_integrated {
WRITE_INTEGRATED_UNSPECIFIED,
diff --git a/zebra/main.c b/zebra/main.c
index ae63793e6..f19ca1b25 100644
--- a/zebra/main.c
+++ b/zebra/main.c
@@ -418,8 +418,8 @@ int main(int argc, char **argv)
zebra_srv6_init();
zebra_srv6_vty_init();
-/* For debug purpose. */
-/* SET_FLAG (zebra_debug_event, ZEBRA_DEBUG_EVENT); */
+ /* For debug purpose. */
+ /* SET_FLAG (zebra_debug_event, ZEBRA_DEBUG_EVENT); */
/* Process the configuration file. Among other configuration
* directives we can meet those installing static routes. Such
diff --git a/zebra/rt_netlink.c b/zebra/rt_netlink.c
index a63188843..dd75b707a 100644
--- a/zebra/rt_netlink.c
+++ b/zebra/rt_netlink.c
@@ -1178,14 +1178,14 @@ static void _netlink_route_build_singlepath(const char *routedesc, int bytelen,
case ZEBRA_SEG6_LOCAL_ACTION_END_X:
addattr32(nlmsg, req_size, SEG6_LOCAL_ACTION,
SEG6_LOCAL_ACTION_END_X);
- addattr_l(nlmsg, req_size, SEG6_LOCAL_NH6,
- &ctx->nh6, sizeof(struct in6_addr));
+ addattr_l(nlmsg, req_size, SEG6_LOCAL_NH6, &ctx->nh6,
+ sizeof(struct in6_addr));
break;
case ZEBRA_SEG6_LOCAL_ACTION_END_DX4:
addattr32(nlmsg, req_size, SEG6_LOCAL_ACTION,
SEG6_LOCAL_ACTION_END_DX4);
- addattr_l(nlmsg, req_size, SEG6_LOCAL_NH4,
- &ctx->nh4, sizeof(struct in_addr));
+ addattr_l(nlmsg, req_size, SEG6_LOCAL_NH4, &ctx->nh4,
+ sizeof(struct in_addr));
break;
default:
zlog_err("%s: unsupport seg6local behaviour action=%u",
@@ -2153,8 +2153,9 @@ static int netlink_nexthop(int cmd, struct zebra_dplane_ctx *ctx)
sizeof(struct in_addr));
break;
default:
- zlog_err("%s: unsupport seg6local behaviour action=%u",
- __func__, action);
+ zlog_err(
+ "%s: unsupport seg6local behaviour action=%u",
+ __func__, action);
break;
}
addattr_nest_end(&req.n, nest);
diff --git a/zebra/zapi_msg.c b/zebra/zapi_msg.c
index e9895f6ae..ab114f980 100644
--- a/zebra/zapi_msg.c
+++ b/zebra/zapi_msg.c
@@ -1089,8 +1089,7 @@ int zsend_zebra_srv6_locator_add(struct zserv *client,
{
struct stream *s = stream_new(ZEBRA_MAX_PACKET_SIZ);
- if (zapi_srv6_locator_encode(ZEBRA_SRV6_LOCATOR_ADD,
- s, locator) < 0) {
+ if (zapi_srv6_locator_encode(ZEBRA_SRV6_LOCATOR_ADD, s, locator) < 0) {
stream_free(s);
return -1;
}
@@ -1103,8 +1102,8 @@ int zsend_zebra_srv6_locator_delete(struct zserv *client,
{
struct stream *s = stream_new(ZEBRA_MAX_PACKET_SIZ);
- if (zapi_srv6_locator_encode(ZEBRA_SRV6_LOCATOR_DELETE,
- s, locator) < 0) {
+ if (zapi_srv6_locator_encode(ZEBRA_SRV6_LOCATOR_DELETE, s, locator)
+ < 0) {
stream_free(s);
return -1;
}
@@ -1688,11 +1687,11 @@ static void zread_route_add(ZAPI_HANDLER_ARGS)
&& api_nh->type != NEXTHOP_TYPE_BLACKHOLE) {
if (IS_ZEBRA_DEBUG_RECV)
zlog_debug("%s: adding seg6local action %s",
- __func__, seg6local_action2str(
+ __func__,
+ seg6local_action2str(
api_nh->seg6local_action));
- nexthop_add_seg6local(nexthop,
- api_nh->seg6local_action,
+ nexthop_add_seg6local(nexthop, api_nh->seg6local_action,
&api_nh->seg6local_ctx);
}
@@ -2777,8 +2776,7 @@ void (*const zserv_handlers[])(ZAPI_HANDLER_ARGS) = {
[ZEBRA_MLAG_FORWARD_MSG] = zebra_mlag_forward_client_msg,
[ZEBRA_SRV6_FUNCTION_ADD] = zrecv_zebra_srv6_function_add,
[ZEBRA_SRV6_FUNCTION_DELETE] = zrecv_zebra_srv6_function_delete,
- [ZEBRA_CLIENT_CAPABILITIES] = zread_client_capabilities
-};
+ [ZEBRA_CLIENT_CAPABILITIES] = zread_client_capabilities};
#if defined(HANDLE_ZAPI_FUZZING)
extern struct zebra_privs_t zserv_privs;
diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index d773d892d..5cd2347da 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -650,11 +650,13 @@ static void vty_show_ip_route(struct vty *vty, struct route_node *rn,
if (nexthop->nh_seg6local_ctx) {
json_seg6local = json_object_new_object();
- json_object_string_add(json_seg6local,
- "action", seg6local_action2str(
- nexthop->nh_seg6local_action));
+ json_object_string_add(
+ json_seg6local, "action",
+ seg6local_action2str(
+ nexthop->nh_seg6local_action));
json_object_object_add(json_nexthop,
- "seg6local", json_seg6local);
+ "seg6local",
+ json_seg6local);
}
json_object_array_add(json_nexthops, json_nexthop);
@@ -787,11 +789,12 @@ static void vty_show_ip_route(struct vty *vty, struct route_node *rn,
if (nexthop->nh_seg6local_ctx) {
seg6local_context2str(buf, sizeof(buf),
- nexthop->nh_seg6local_ctx,
- nexthop->nh_seg6local_action);
+ nexthop->nh_seg6local_ctx,
+ nexthop->nh_seg6local_action);
vty_out(vty, ", seg6local %s %s",
seg6local_action2str(
- nexthop->nh_seg6local_action), buf);
+ nexthop->nh_seg6local_action),
+ buf);
}
if (uptime < ONE_DAY_SECOND)
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/U1604I386/config.status/config.status Ubuntu 14.04 amd64 build: Failed (click for details)Make failed for Ubuntu 14.04 amd64 build: Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI001BUILD/config.status/config.status Debian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build: Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI008BLD/config.status/config.status FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/FBSD12AMD64/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI011BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI012BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI014BUILD/config.status/config.status FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI009BUILD/config.status/config.status NetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build: NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI007BUILD/config.status/config.status Successful on other platforms
Warnings Generated during build:Checkout code: Successful with additional warningsUbuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/U1604I386/config.status/config.status Ubuntu 14.04 amd64 build: Failed (click for details)Make failed for Ubuntu 14.04 amd64 build: Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI001BUILD/config.status/config.status Debian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build: Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI008BLD/config.status/config.status FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/FBSD12AMD64/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI011BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI012BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI014BUILD/config.status/config.status FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI009BUILD/config.status/config.status NetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build: NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10865/artifact/CI007BUILD/config.status/config.status Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
slankdev
force-pushed
the
slankdev-zebra-srv6-manager
branch
from
3686f9d to
1af5b33
Compare
|
Above force-push fix the code-format depending this PR. |
Outdated results 🛑Basic BGPD CI results: FAILURE
| For details, please contact louberger |
|
CI Error while building stage isn't fixed yet. now I'm just working for that. Also, BGPD CI error, I'll check that. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedDebian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build: Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI008BLD/config.status/config.status FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI009BUILD/config.status/config.status NetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build: NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI007BUILD/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI011BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI014BUILD/config.status/config.status FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/FBSD12AMD64/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI012BUILD/config.status/config.status Ubuntu 14.04 amd64 build: Failed (click for details)Make failed for Ubuntu 14.04 amd64 build: Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI001BUILD/config.status/config.status Ubuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/U1604I386/config.status/config.status Successful on other platforms
Warnings Generated during build:Checkout code: Successful with additional warningsDebian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build: Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI008BLD/config.status/config.status FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI009BUILD/config.status/config.status NetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build: NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI007BUILD/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI011BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI014BUILD/config.status/config.status FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/FBSD12AMD64/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI012BUILD/config.status/config.status Ubuntu 14.04 amd64 build: Failed (click for details)Make failed for Ubuntu 14.04 amd64 build: Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/CI001BUILD/config.status/config.status Ubuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10909/artifact/U1604I386/config.status/config.status Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
|
For-future-contributors-Notes: About CI error with following compiler notes. This is depending Lines 26 to 31 in 8105c99 |
slankdev
force-pushed
the
slankdev-zebra-srv6-manager
branch
from
1af5b33 to
4cab585
Compare
|
Above force-push may fix the compile error on ubuntu16.04 and more. (fix CI error) |
Outdated results 🛑Basic BGPD CI results: FAILURE
| For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/CI009BUILD/config.status/config.status NetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build: NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/CI007BUILD/config.status/config.status FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/FBSD12AMD64/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/CI011BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/CI012BUILD/config.status/config.status Successful on other platforms
Warnings Generated during build:Checkout code: Successful with additional warningsFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/CI009BUILD/config.status/config.status NetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build: NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/CI007BUILD/config.status/config.status FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/FBSD12AMD64/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/CI011BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10910/artifact/CI012BUILD/config.status/config.status Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
slankdev
force-pushed
the
slankdev-zebra-srv6-manager
branch
from
4cab585 to
346f80d
Compare
|
Above force-push may fix BSD build failure. There are FreeBSD definition. There are Linux defiinition. |
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
slankdev
commented
Mar 1, 2020
slankdev
force-pushed
the
slankdev-zebra-srv6-manager
branch
from
346f80d to
315a367
Compare
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10911/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warningsWarnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10912/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings |
odd22
requested changes
Mar 2, 2020
riw777
reviewed
Mar 3, 2020
|
Yes, please run a spellchecking tool over your docs. |
qlyoung
requested changes
Mar 3, 2020
|
@qlyoung Catch now. But I hate goto and label D:< |
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
The "show sharp segment-routing srv6" command was a json output command, but it did not follow the common practice of the other commands. It follows the review and outputs the json format by using the json keyword. Otherwise, it produces human readable output. Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
FRRouting#5865 (comment) As this comment says. ZEBRA_FLAG_XXX should not have been used. To communicate SRv6 Route Information. A simple Nexthop Flag would have been sufficient for SRv6 information. And I fixed the whole thing that way. Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
mjstapp
force-pushed
the
slankdev-zebra-srv6-manager
branch
from
20e58b3 to
2ba6be5
Compare
polychaeta
reviewed
Jun 2, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/srv6_locator/test_srv6_locator.py:
************* Module srv6_locator.test_srv6_locator
my_frr/tests/topotests/srv6_locator/test_srv6_locator.py:65:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.38/10
Pylint report for my_frr/tests/topotests/zebra_seg6_route/test_zebra_seg6_route.py:
************* Module test_zebra_seg6_route
my_frr/tests/topotests/zebra_seg6_route/test_zebra_seg6_route.py:55:0: E0102: class already defined line 44 (function-redefined)
-----------------------------------
Your code has been rated at 9.14/10
Pylint report for my_frr/tests/topotests/zebra_seg6local_route/test_zebra_seg6local_route.py:
************* Module test_zebra_seg6local_route
my_frr/tests/topotests/zebra_seg6local_route/test_zebra_seg6local_route.py:55:0: E0102: class already defined line 44 (function-redefined)
-----------------------------------
Your code has been rated at 9.14/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
|
I've pushed an updated version of the branch that a) builds at each commit, and b) squashes some of the commits together. |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-19370/test Topology Tests failed for Topotests debian 10 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19370/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-19370/test Topology Tests failed for Topotests debian 10 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19370/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 18.04: Incomplete(check logs for details)Topotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-19370/test Topology Tests failed for Topotests debian 10 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19370/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-19370/test Topology Tests failed for Topotests debian 10 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19370/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 18.04: Incomplete(check logs for details)IPv4 protocols on Ubuntu 18.04: Incomplete(check logs for details)Successful on other platforms/tests
|
|
CI:rerun |
|
re-trying CI, hopefully fixed today |
|
CI:rerun |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 18.04 arm7 build: Failed (click for details)DejaGNU Unittests (make check) failed for Ubuntu 18.04 arm7 build Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsUbuntu 18.04 arm7 build: Failed (click for details)DejaGNU Unittests (make check) failed for Ubuntu 18.04 arm7 build |
|
CI:rerun |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19431/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings |
|
Checked with Quentin about his comments, and we're going ahead and merging. |
|
@mjstapp I believe that this PR merge is just the start, and I would like to contribute to the development of additional features and improvements to the FRRouting architecture that may occur in the future. In addition, the kernel already supports DT4, and we are planning to conduct more tests including interop with current Enterprise NOS (JUNOS, IOS-XR, etc.). Again, many thanks. |
|
Thank you for your contribution, and for your patience through the long review process. maybe next time we can work out ways to bring work in in smaller chunks that will be easier for the community to review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #5853 that work as following:
Easiest way to play this feature:: execute topotest
ref : http://docs.frrouting.org/projects/dev-guide/en/latest/topotests.html
This PR isn't working for (following are nextstep):
This branch is tested On